Add support for CA certificate for auth provider#3044
Add support for CA certificate for auth provider#3044lgutter wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
@lgutter is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
@rossnelson @Alex-Tideman Any chance you can look at this? :) |
|
@rossnelson @Alex-Tideman just a friendly reminder for this MR, would love to get this merged! |
|
Hey, can we proceed with this please? This is a really necessary feature |
|
@laurakwhit @rossnelson any chance you could have a look at this? it's a simple change with big impact for those who need it. |
rossnelson
left a comment
There was a problem hiding this comment.
Thanks @lgutter I left a few small comments, let me know what you think.
When using an SSO provider with a certificate signed by our own internal CA, the ui server is currently unable to verify the certificate. This change adds support for providing a CA certificate to enable verification of the used certificate.
46161c0 to
a41b0e8
Compare
Thank you for the review @rossnelson. I completely agree with your feedback and have updated accordingly. Let me know if you need anything else from me to get this merged! |
Description & motivation 💭
When using an SSO provider with a certificate signed by our own internal CA, the ui server is currently unable to verify the certificate. This change adds support for providing a CA certificate to enable verification of the used certificate.
Screenshots (if applicable) 📸
N/A
Design Considerations 🎨
minimal impact, only used IF a CA cert is provided.
Testing 🧪
Added tests and I already use this to connect to a self-hosted keycloak.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Deploy this new version & provide a caFile or caData (base64 encoded) to trust a custom certificate for SSO.
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
#2957
Docs
Any docs updates needed?
Changes required are mimimal, but the env vars for web UI should be updated with: