Skip to content

Log rejection of polls from recently-shutdown workers #9811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkannan82 merged 5 commits into from
Apr 7, 2026
+6 −0
Merged

Log rejection of polls from recently-shutdown workers #9811

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b335f6e
Log when rejecting poll from recently-shutdown worker
rkannan82 Apr 3, 2026
3772f05
Merge branch 'main' into kannan/log-shutdown-poll-rejection
rkannan82 Apr 7, 2026
e49af06
Add namespace ID and task queue type tags to shutdown rejection log
rkannan82 Apr 7, 2026
2bd82fc
Merge branch 'main' into kannan/log-shutdown-poll-rejection
rkannan82 Apr 7, 2026
9e7796f
Merge branch 'main' into kannan/log-shutdown-poll-rejection
rkannan82 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions service/matching/matching_engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2859,6 +2859,10 @@ func (e *matchingEngineImpl) pollTask(
// returned to the handler before a context timeout error is generated.
workerInstanceKey := pollMetadata.workerInstanceKey
if workerInstanceKey != "" && e.shutdownWorkers.Get(workerInstanceKey) != nil {
e.logger.Info("Rejecting poll from recently-shutdown worker",
tag.WorkflowTaskQueueName(partition.TaskQueue().Name()),
tag.NewStringTag("worker-instance-key", workerInstanceKey),
)
return nil, false, errNoTasks
}

Expand Down
Loading