Skip to content

Dispatch activity cancellation to worker using Nexus #9233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkannan82 wants to merge 65 commits into
base: main
Choose a base branch
from
Open

Dispatch activity cancellation to worker using Nexus #9233

Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
31e35cd
Store worker_instance_key in ActivityInfo
rkannan82 Feb 4, 2026
2874f4e
Add unit test
rkannan82 Feb 5, 2026
ad8c480
Fix lint
rkannan82 Feb 5, 2026
986e9a1
Remove redundant WorkerInstanceKey assignment in UpdateActivity callback
rkannan82 Feb 9, 2026
fb3066c
Store worker_control_task_queue in ActivityInfo
rkannan82 Feb 11, 2026
6ef2640
Update go.temporal.io/api to include worker_instance_key and worker_c…
rkannan82 Feb 11, 2026
eab94b0
Fix lint
rkannan82 Feb 11, 2026
0f8e48e
Remove worker_instance_key as it is not needed
rkannan82 Feb 12, 2026
5390759
Forward WorkerControlTaskQueue through matching service partitions
rkannan82 Feb 18, 2026
ac7be08
Define CancelActivityNexusTask transfer task type
rkannan82 Feb 3, 2026
113ca15
Fix lint errors
rkannan82 Feb 6, 2026
5ad9aeb
Regen proto
rkannan82 Feb 11, 2026
05adf1a
Remove worker_instance_key as it is not needed
rkannan82 Feb 12, 2026
39c1759
Move CancelActivityNexusTask creation to task_generator
rkannan82 Feb 12, 2026
131c278
Add WorkerControlTaskQueue to CancelActivityNexusTask
rkannan82 Feb 12, 2026
7bc8ada
Add metrics tag and low priority for CancelActivityNexusTask
rkannan82 Feb 12, 2026
01e4822
Update comment for standby executor
rkannan82 Feb 12, 2026
e9b1fac
Add Version field to CancelActivityNexusTask for multi-cluster support
rkannan82 Feb 12, 2026
faff7ee
Add comment
rkannan82 Feb 12, 2026
d6af322
Add ActivityCommandTask for outbound activity commands
rkannan82 Feb 18, 2026
7f5e0fc
Regenerate mocks with go-generate for correct ordering and parameter …
rkannan82 Feb 18, 2026
cd17334
Change ActivityCommandTask to use task_tokens instead of scheduled_ev…
rkannan82 Feb 18, 2026
6a1a66b
Change ActivityCommandTaskInfo to WorkerCommandsTask
rkannan82 Feb 25, 2026
fbf13b0
Add ActivityCommandTask dispatch via Nexus
rkannan82 Feb 18, 2026
d5591a4
Update api-go dependency to merged activity-cancel branch
rkannan82 Mar 13, 2026
537edb9
Merge branch 'kannan/activity-cancel/task-definition' into kannan/act…
rkannan82 Mar 13, 2026
d182f84
Update dispatcher to use WorkerCommandsRequest from nexusservices pac…
rkannan82 Mar 13, 2026
0f6651c
Update dispatcher for ExecuteCommands rename and extracted types
rkannan82 Mar 13, 2026
7f842cf
Generalize task to WorkerCommandsTask using API WorkerCommand type
rkannan82 Mar 13, 2026
2150c89
Merge branch 'kannan/activity-cancel/task-definition' into kannan/act…
rkannan82 Mar 13, 2026
1b85cce
Update dispatcher and integration test for WorkerCommandsTask
rkannan82 Mar 13, 2026
404ce2a
Rename TASK_TYPE_ACTIVITY_COMMAND to TASK_TYPE_WORKER_COMMANDS and re…
rkannan82 Mar 13, 2026
54232d3
Merge branch 'kannan/activity-cancel/task-definition' into kannan/act…
rkannan82 Mar 13, 2026
3e0a3a0
Rename activity_command_task.go to worker_commands_task.go
rkannan82 Mar 13, 2026
05a7c1d
Merge branch 'kannan/activity-cancel/task-definition' into kannan/act…
rkannan82 Mar 13, 2026
6614c3e
Add worker commands dispatcher with Nexus response handling and unit …
rkannan82 Mar 31, 2026
64c52e9
Fix lint errors: gofmt alignment, testifylint, importas, staticcheck,…
rkannan82 Mar 31, 2026
7343da1
Refactor worker commands dispatcher: deduplicate failure handling, re…
rkannan82 Mar 31, 2026
66dd3fb
Clean up dispatch response handling: inline failure conversion, impro…
rkannan82 Mar 31, 2026
dfac6d2
Store started_clock in ActivityInfo for task token reconstruction
rkannan82 Apr 1, 2026
29ac6e5
Cap worker commands task retries at 3 attempts
rkannan82 Apr 1, 2026
3fd7447
Add retry cap comment to dispatcher failure scenarios doc
rkannan82 Apr 1, 2026
412045e
Emit metric when dropping worker commands task at retry cap
rkannan82 Apr 1, 2026
083d313
Clarify attempt parameter in test calls with inline comment
rkannan82 Apr 1, 2026
8dec8b4
Update go.mod to latest api-go (includes API PR #708)
rkannan82 Apr 7, 2026
3e4267f
Address review feedback: backward compat, standby executor, lock safety
rkannan82 Apr 10, 2026
ca17749
Remove replace directive and update go.temporal.io/api to v1.62.8
rkannan82 Apr 11, 2026
0549e23
Fix compile error in convertTemporalFailure: := to = for named returns
rkannan82 Apr 11, 2026
466f4d2
Remove redundant StartedEventId check in cancel activity handler
rkannan82 Apr 11, 2026
061cc39
Merge origin/main into kannan/activity-cancel/dispatch-logic
rkannan82 Apr 11, 2026
e3a08a5
Revert executable_mock.go to main (Attempt() already merged via #9924)
rkannan82 Apr 11, 2026
8846349
Fix nits: align metric defs, replace assert with require in tests
rkannan82 Apr 11, 2026
3c4e62c
Remove unused common import in handler test
rkannan82 Apr 11, 2026
6a890ba
Replace workerservicepb.WorkerService with string constants
rkannan82 Apr 11, 2026
3420f9a
Fix GCI lint: alphabetize imports and align struct fields in test
rkannan82 Apr 11, 2026
56e9b73
Fix nil Clock in duplicate RecordActivityTaskStarted for pre-deploy a…
rkannan82 Apr 14, 2026
9859175
Improve RecordActivityTaskStarted test coverage and naming
rkannan82 Apr 14, 2026
7ef2b52
Add integration test for duplicate RecordActivityTaskStarted
rkannan82 Apr 14, 2026
a6ac85f
Address review feedback: move metric, check handler error retryability
rkannan82 Apr 14, 2026
0f546ca
Add description to WorkerCommandsSent metric
rkannan82 Apr 14, 2026
f4fe808
Use SDK failure converter instead of Nexus failure conversion
rkannan82 Apr 14, 2026
aa9dd98
Use retryable matching client for worker commands dispatch
rkannan82 Apr 14, 2026
7966342
Fix formatting alignment
rkannan82 Apr 14, 2026
c271f43
Merge branch 'main' into kannan/activity-cancel/dispatch-logic
rkannan82 Apr 15, 2026
d7190ef
Fix proto depIdxs conflict and test dependency for MatchingClient
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/enums/v1/task.go-helpers.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions api/enums/v1/task.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions api/persistence/v1/executions.go-helpers.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading