Skip to content
Open
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b37d25e
Add "exposed" operation for system nexus endpoint
spkane31 Mar 18, 2026
d70e3ca
merge conflicts
spkane31 Mar 18, 2026
b517764
linter fixes
spkane31 Mar 18, 2026
f0760b3
remove local nexusannotations and use nexus-rpc repo
spkane31 Mar 24, 2026
3f17a76
add nexus annotations to buf.yaml
spkane31 Mar 25, 2026
ba43a56
buf.lock
spkane31 Mar 25, 2026
ab1b41d
add target to Makefile for downloading updates
spkane31 Mar 25, 2026
e263cf2
Merge branch 'master' of github.com:temporalio/api into spk/signal-wi…
spkane31 Mar 30, 2026
4979ae3
Merge branch 'master' of github.com:temporalio/api into spk/signal-wi…
spkane31 Apr 3, 2026
65d1c56
first draft of a nexusrpc{.langs}.yaml files
spkane31 Apr 3, 2026
9558edf
use json pointer format instead of dot notation
spkane31 Apr 3, 2026
d10e568
change file names
spkane31 Apr 6, 2026
863d3f3
Merge branch 'master' of github.com:temporalio/api into spk/signal-wi…
spkane31 Apr 6, 2026
d249bb6
add typescript and python Refs
spkane31 Apr 6, 2026
54fa5c4
Merge branch 'master' of github.com:temporalio/api into spk/signal-wi…
spkane31 Apr 6, 2026
1152ac5
addressing review comments
spkane31 Apr 13, 2026
c267398
install from nexus-rpc/nexus-rpc-gen repo
spkane31 Apr 13, 2026
c3e6d26
tests
spkane31 Apr 14, 2026
adecd33
Merge branch 'master' of github.com:temporalio/api into spk/signal-wi…
spkane31 Apr 14, 2026
1b7b2b5
proto
spkane31 Apr 14, 2026
87be9e8
merge conflicts
spkane31 Apr 16, 2026
e9a0f6c
ci-build
spkane31 Apr 16, 2026
e150e41
remove test files
spkane31 Apr 16, 2026
5ab04f0
remove test deps
spkane31 Apr 16, 2026
4131b90
generate types into #/components/schemas directly in nexus json schem…
spkane31 Apr 17, 2026
0e58e7d
/components/schemas -> /types
spkane31 Apr 17, 2026
c6d6808
generate proto refs for grpc requests and responses
spkane31 Apr 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ci-build: install proto http-api-docs
install: grpc-install api-linter-install buf-install

# Run all linters and compile proto files.
proto: grpc http-api-docs
proto: sync-nexus-annotations grpc http-api-docs
########################################################################

##### Variables ######
Expand Down Expand Up @@ -95,6 +95,11 @@ buf-install:
printf $(COLOR) "Install/update buf..."
go install github.com/bufbuild/buf/cmd/buf@v1.27.0

##### Sync external proto dependencies #####
sync-nexus-annotations:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we have the same make target for google? Seems like we can sync both. But probably don't sync google as part of this PR if there are any changes there, better to do that separately.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes in the google/api definitions that we don't have in this repo, do we want to add all of those all at once?
https://buf.build/googleapis/googleapis/docs/main%3Agoogle.api

printf $(COLOR) "Sync nexusannotations from buf.build/temporalio/nexus-annotations..."
buf export buf.build/temporalio/nexus-annotations --output .

##### Linters #####
api-linter:
printf $(COLOR) "Run api-linter..."
Expand Down
13 changes: 9 additions & 4 deletions buf.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,15 @@ deps:
- remote: buf.build
owner: googleapis
repository: googleapis
commit: 28151c0d0a1641bf938a7672c500e01d
digest: shake256:49215edf8ef57f7863004539deff8834cfb2195113f0b890dd1f67815d9353e28e668019165b9d872395871eeafcbab3ccfdb2b5f11734d3cca95be9e8d139de
commit: 004180b77378443887d3b55cabc00384
digest: shake256:d26c7c2fd95f0873761af33ca4a0c0d92c8577122b6feb74eb3b0a57ebe47a98ab24a209a0e91945ac4c77204e9da0c2de0020b2cedc27bdbcdea6c431eec69b
- remote: buf.build
owner: grpc-ecosystem
repository: grpc-gateway
commit: 048ae6ff94ca4476b3225904b1078fad
digest: shake256:e5250bf2d999516c02206d757502b902e406f35c099d0e869dc3e4f923f6870fe0805a9974c27df0695462937eae90cd4d9db90bb9a03489412560baa74a87b6
commit: 6467306b4f624747aaf6266762ee7a1c
digest: shake256:833d648b99b9d2c18b6882ef41aaeb113e76fc38de20dda810c588d133846e6593b4da71b388bcd921b1c7ab41c7acf8f106663d7301ae9e82ceab22cf64b1b7
- remote: buf.build
owner: temporalio
repository: nexus-annotations
commit: 599b78404fbe4e78b833d527a1d0da40
digest: shake256:1f41ef11ccbf31d7318b0fe1915550ba6567c99dc94694d60b117fc1ffc756290ba9766c58b403986f079e2b861b42538e5f8cf0495f744cd390d223b81854ca
3 changes: 3 additions & 0 deletions buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@ name: buf.build/temporalio/api
deps:
- buf.build/grpc-ecosystem/grpc-gateway
- buf.build/googleapis/googleapis
- buf.build/temporalio/nexus-annotations
build:
excludes:
# Buf won't accept a local dependency on the google protos but we need them
# to run api-linter, so just tell buf it ignore it
- google
# Same for nexusannotations - local copy for api-linter, BSR dep for buf
- nexusannotations
breaking:
use:
- WIRE_JSON
Expand Down
29 changes: 29 additions & 0 deletions nexusannotations/v1/options.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
syntax = "proto3";

package nexusannotations.v1;

import "google/protobuf/descriptor.proto";

option go_package = "github.com/nexus-rpc/nexus-proto-annotations/go/nexusannotations/v1";

extend google.protobuf.ServiceOptions {
optional ServiceOptions service = 8233;
}

extend google.protobuf.MethodOptions {
optional OperationOptions operation = 8234;
}

message OperationOptions {
// Nexus operation name (defaults to proto method name).
string name = 1;
// Tags to attach to the operation. Used by code generators to include and exclude operations.
repeated string tags = 2;
}

message ServiceOptions {
// Nexus service name (defaults to proto service full name).
string name = 1;
// Tags to attach to the service. Used by code generators to include and exclude services.
repeated string tags = 2;
}
5 changes: 4 additions & 1 deletion temporal/api/workflowservice/v1/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ option ruby_package = "Temporalio::Api::WorkflowService::V1";
option csharp_namespace = "Temporalio.Api.WorkflowService.V1";


import "temporal/api/workflowservice/v1/request_response.proto";
import "google/api/annotations.proto";
import "nexusannotations/v1/options.proto";
import "temporal/api/protometa/v1/annotations.proto";
import "temporal/api/workflowservice/v1/request_response.proto";

// WorkflowService API defines how Temporal SDKs and other clients interact with the Temporal server
// to create and interact with workflows and activities.
Expand Down Expand Up @@ -487,6 +488,8 @@ service WorkflowService {
// (-- api-linter: core::0136::prepositions=disabled
// aip.dev/not-precedent: "With" is used to indicate combined operation. --)
rpc SignalWithStartWorkflowExecution (SignalWithStartWorkflowExecutionRequest) returns (SignalWithStartWorkflowExecutionResponse) {
option (nexusannotations.v1.operation).tags = "exposed";

option (google.api.http) = {
post: "/namespaces/{namespace}/workflows/{workflow_id}/signal-with-start/{signal_name}"
body: "*"
Expand Down
Loading