Migrate demos 2-4 to new temporal-spring-ai plugin#1
Open
donald-pinckney wants to merge 2 commits intotemporal-community:mainfrom
Open
Migrate demos 2-4 to new temporal-spring-ai plugin#1donald-pinckney wants to merge 2 commits intotemporal-community:mainfrom
donald-pinckney wants to merge 2 commits intotemporal-community:mainfrom
Conversation
Replace the prototype io.temporal.ai:temporal-spring-ai:0.0.1-SNAPSHOT with the official io.temporal:temporal-spring-ai:1.35.0-SNAPSHOT from the Temporal Java SDK. Changes across all demos: - Import renames: io.temporal.ai.chat.* -> io.temporal.springai.* - POM: new groupId, version, bumped spring-ai to 1.1.0, temporal-sdk to 1.35.0-SNAPSHOT - Remove chatModelActivity/mcpClientActivityImpl from activity-beans (auto-registered by SpringAiPlugin/McpPlugin via auto-configuration) - Remove @componentscan overrides (plugin uses auto-config, not scanning) - API rename: McpToolCallback.fromMcpTools() -> fromMcpClient() - Replace pre-built jar in lib/ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
donald-pinckney
changed the title
Only temporal-spring-ai needs to be a SNAPSHOT (not yet released). The SDK itself at 1.34.0 already has SimplePlugin and everything the plugin needs at runtime. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the prototype
io.temporal.ai:temporal-spring-ai:0.0.1-SNAPSHOTwith the officialio.temporal:temporal-spring-ai:1.35.0-SNAPSHOTfrom the Temporal Java SDK (temporalio/sdk-java#2829).Changes
io.temporalgroupId,1.35.0-SNAPSHOTversion)spring-aito 1.1.0 andtemporal-sdkto 1.35.0-SNAPSHOTio.temporal.ai.chat.*→io.temporal.springai.*(4 Java files)McpToolCallback.fromMcpTools()→McpToolCallback.fromMcpClient()chatModelActivityandmcpClientActivityImplfromactivity-beans— the plugin now auto-registers these via Spring Boot auto-configuration@ComponentScanoverrides — the plugin uses auto-configuration instead of component scanningWhat the official plugin provides
The official
temporal-spring-aimodule uses conditional auto-configuration to register activities automatically:SpringAiPluginalways registersChatModelActivity(core)McpPluginregistersMcpClientActivitywhen MCP is on the classpathVerification
All three demos compile and demo2 boots successfully with the plugin auto-registering activities.
Dependencies
🤖 Generated with Claude Code