-
Notifications
You must be signed in to change notification settings - Fork 99
feat(data-grid): support inline html cells #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PapeThePope
wants to merge
2
commits into
telekom:main
Choose a base branch
from
PapeThePope:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
packages/components/src/components/data-grid/data-grid.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /** | ||
| * @license | ||
| * Scale https://github.com/telekom/scale | ||
| * | ||
| * Copyright (c) 2021 Egor Kirpichev and contributors, Deutsche Telekom AG | ||
| * | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| */ | ||
|
|
||
| import { newSpecPage } from '@stencil/core/testing'; | ||
| import { DataGrid } from './data-grid'; | ||
| import { HTMLCell } from './cell-handlers/html-cell'; | ||
|
|
||
| class ResizeObserverMock { | ||
| observe() {} | ||
| unobserve() {} | ||
| } | ||
|
|
||
| describe('DataGrid', () => { | ||
| beforeEach(() => { | ||
| (globalThis as any).ResizeObserver = ResizeObserverMock; | ||
| }); | ||
|
|
||
| it('renders html cell content inline when display is inline', async () => { | ||
| const inlineButton = document.createElement('button'); | ||
| inlineButton.textContent = 'Open details'; | ||
|
|
||
| const page = await newSpecPage({ | ||
| components: [DataGrid], | ||
| html: '<scale-data-grid></scale-data-grid>', | ||
| }); | ||
|
|
||
| page.root.fields = [ | ||
| { | ||
| type: 'html', | ||
| display: 'inline', | ||
| label: 'Action', | ||
| width: 120, | ||
| }, | ||
| ]; | ||
| page.root.rows = [[inlineButton]]; | ||
|
|
||
| await page.waitForChanges(); | ||
|
|
||
| expect(page.root.shadowRoot.querySelector('.tbody__nested')).toBeNull(); | ||
| expect( | ||
| page.root.shadowRoot.querySelector('.tbody__cell button').textContent | ||
| ).toBe('Open details'); | ||
| }); | ||
|
|
||
| it('keeps html cell content nested by default', async () => { | ||
| const nestedContent = document.createElement('div'); | ||
| nestedContent.textContent = 'Nested details'; | ||
|
|
||
| const page = await newSpecPage({ | ||
| components: [DataGrid], | ||
| html: '<scale-data-grid></scale-data-grid>', | ||
| }); | ||
|
|
||
| page.root.fields = [ | ||
| { | ||
| type: 'html', | ||
| label: 'Details', | ||
| width: 96, | ||
| }, | ||
| ]; | ||
| page.root.rows = [[nestedContent]]; | ||
|
|
||
| await page.waitForChanges(); | ||
|
|
||
| expect( | ||
| page.root.shadowRoot.querySelector('.tbody__cell scale-button') | ||
| ).toBeTruthy(); | ||
| expect( | ||
| page.root.shadowRoot.querySelector('.tbody__nested div').textContent | ||
| ).toBe('Nested details'); | ||
| }); | ||
|
|
||
| it('uses the longest inline html content for auto width checks', () => { | ||
| const shortButton = document.createElement('button'); | ||
| shortButton.textContent = 'Open'; | ||
| const longButton = document.createElement('button'); | ||
| longButton.textContent = 'Open ticket details'; | ||
|
|
||
| const longestContent = HTMLCell.getLongestContent({ | ||
| rows: [[shortButton], [longButton]], | ||
| columnIndex: 0, | ||
| field: { display: 'inline' }, | ||
| }); | ||
|
|
||
| expect(longestContent).toBe(longButton); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.