Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether a window shows the info column is decided by one app-wide setting,
thirdSectionInfoEnabled().SessionController::computeColumnLayout()allows the three column layout only while it is on,MainWidget::updateControlsGeometry()creates or destroys the third section from the layout, and the top bar info button shows and toggles the column from the same setting.Only the window where the column was toggled laid itself out again. Other windows kept their column until their own next layout update, while their info buttons already showed the new value. For example, with a chat opened in a separate window, toggling the info column in one window left the other one out of sync, so its button closed a column that wasn't shown or opened one that already was, and the two windows seemed to toggle each other inversely.
MainWidgetnow updates its column layout when the setting changes, so every window with enough room shows or hides the column together. The update is queued, becauseSessionController::resizeForThirdSection()turns the setting off and back on while it extends the window.Testing
Built and tested on macOS (Debug), with a chat opened in a separate window: