Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a forum from the chat list shows its topics in a separate column, with the chat list narrowed to userpics on its left.
Dialogs::Widget::showForum()does that throughopenChildList(), but only when the chat list is not collapsed. When it is collapsed, the forum is opened throughchangeOpenedForum(), which shows the topics in place of the chats.That choice was not revisited when the chat list was expanded afterwards. For example, collapsing the chat list, opening a forum and then expanding the list kept the topics in place of the chats, without the chat list column that opening the same forum from the expanded list shows.
Now
showForum()remembers when it was asked for a child column and fell back tochangeOpenedForum()only because the chat list was collapsed. When the chat list is expanded,resizeEvent()opens the forum again in the child column. Forums opened without a child column, for example from a profile, keep their layout, and so do forums with the Hide chat list in forums option enabled.Testing
Built and tested on macOS (Debug):