Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the collapsed chat list,
ForumTopic::paintUserpic()centers a topic's icon vertically within the height of its row style,st::forumTopicRow(54px). Collapsed topic rows are taller than that:Row::recountHeight()interpolates a topic row's height tost::defaultDialogRow.height(62px) as the list narrows. So in the collapsed list the icon was drawn 4px above the center of its row.Both narrow branches of
paintUserpic(), for custom emoji icons and for default icons, now center withinst::defaultDialogRow.height, the height collapsed rows actually have. The wide layout positions the icon from the row padding and is unchanged, so the expanded topics list and the topic list in the forward box look the same as before.Testing
Built and tested on macOS (Debug):
Screenshots