Fix clipped descenders in the group-call participant name - #31265
Open
anriltine wants to merge 1 commit into
Open
Fix clipped descenders in the group-call participant name#31265anriltine wants to merge 1 commit into
anriltine wants to merge 1 commit into
Conversation
The short-info cover uses a 15px semibold name label, but maxHeight was 19px, which is below the font line height, so glyphs such as g and y were cut off. Fix telegramdesktop#31264 Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoverItem/PeerShortInfoCover) clips descenders in the name. Letters such as g and y in a name like "Ignatyev" are cut off along the bottom.shortInfoCover(inherited bygroupCallMenuCover) uses a 15px semiboldFlatLabelwithmaxHeight: 19px.FlatLabelsizes itself tomin(textHeight, maxHeight), so 19px is below the font line height and the widget clips the glyphs.maxHeightto 24px, matching the profile cover name cap (infoProfileCoveralready uses 24px for a similar semibold name). This is a ceiling, not a fixed height, so a single line still sizes to the font metrics and does not overlap the status line.Fixes #31264
Test plan
g,y,p,j,q).Made with Cursor