Announce selecting and deselecting a message - #31171
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Announce selecting and deselecting a message#31171rezabakhshilaktasaraei wants to merge 1 commit into
rezabakhshilaktasaraei wants to merge 1 commit into
Conversation
Space on a message, and Shift with the arrows, changed the selection without a screen reader saying so: the change was reported through a state change event, which the Windows bridge reads only the checked flag out of. Raise the selection event that does reach it, telling apart a message that just became selected from one that stopped being.
rezabakhshilaktasaraei
force-pushed
the
message-selection-announcement
branch
from
August 25, 2026 07:05
a94d51c to
19f15b8
Compare
rezabakhshilaktasaraei
marked this pull request as ready for review
August 25, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Space on a message, or extending the selection with Shift and the arrows, changes the selection without a screen reader saying anything about it.
The change was reported with a state change event carrying the selected flag. That flag is right as a "this is what changed" mask, but the Windows bridge reads only the checked flag out of a state change (qwindowsuiamainprovider.cpp, notifyStateChange), so nothing came out of it. Both message lists now also raise the selection event that does reach a screen reader; the state change is kept for the platforms that do read it.
Needs desktop-app/lib_ui#345 for accessibilityChildSelectionChanged().
Tested with NVDA on Windows 10: selecting a message announces "selected", deselecting it announces "not selected", and the same holds for the messages a Shift+arrow range grows over or gives back.