Move TypeScript bindings to bindings/ts - #104
Merged
Merged
Conversation
Keeps the top-level bindings/ directory language-neutral so bindings for other languages can live alongside. The default export dir is set via [env] in .cargo/config.toml; an explicit TS_RS_EXPORT_DIR (devtools export-ts-types) still overrides it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Perf numbers for the question raised after #103, measured on the merge commit vs its first parent (identical toolchain,
Δ = −720 bytes — link-layout noise. The generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #103, per post-merge feedback: keep the top-level
bindings/directory language-neutral so bindings for other languages (Kotlin, Swift, ...) can live alongside the TypeScript ones later.What this does
bindings/tobindings/ts/[env]in.cargo/config.toml(relative = true, so it resolves against the repo root regardless of where cargo runs). A plaincargo testkeeps regenerating the committed files in placedevtools export-ts-types [dir]is unaffected: it setsTS_RS_EXPORT_DIRexplicitly, and cargo's[env]default only applies when the variable is unset — verified both pathsbindings/, so future languages inherit it for freeThe frontend branch (teambtcmap/btcmap.org#1243, unmerged) already points its
pnpm types:apiatbindings/ts— it fetches from master, so it needs this PR to land first.Binary-size measurement for the perf question raised after #103 is running; numbers will follow as a comment.
🤖 Generated with Claude Code