[await-dictionary] add runtime keyed Promise combinator tests by danialasaria · Pull Request #4932 · tc39/test262

danialasaria · 2026-02-18T19:43:08Z

Summary

This PR adds the first runtime/behavioral coverage for the await-dictionary proposal’s Promise keyed combinators:

Promise.allKeyed
Promise.allSettledKeyed

It follows the initial boilerplate-only PR and focuses on high-signal success/failure semantics and ordering behavior.

What this PR covers

Shared coverage for both methods

For both Promise.allKeyed and Promise.allSettledKeyed, this PR adds tests for:

rejecting when promises is not an Object (primitive matrix: undefined, null, number, string, boolean, symbol)
throwing when invoked with a non-constructor receiver (NewPromiseCapability path)
rejecting when the constructor’s resolve is non-callable (GetPromiseResolve / IfAbruptRejectPromise path)
resolving {} to an empty null-prototype result object
ignoring non-enumerable own properties
preserving output key order from property enumeration order (not settlement order)

`Promise.allKeyed`-specific

rejection from a synchronously rejected input promise
rejection from an asynchronously rejected input promise

`Promise.allSettledKeyed`-specific

all-fulfilled keyed results with { status: "fulfilled", value }
all-rejected keyed results with { status: "rejected", reason }
mixed fulfilled/rejected keyed results with correct per-key shapes

Notes

All tests are feature-gated with features: [await-dictionary].
New tests mirror existing naming/style patterns used in Promise/all and Promise/allSettled.
These tests intentionally validate keyed combinator result-object behavior (including null-prototype output), which differs from array-based combinators.

What this PR does not cover

This PR intentionally leaves some deeper edge paths for follow-up work, including:

constructor-throws / malformed promise capability variants
promiseResolve throwing or returning a non-thenable
exotic object abrupt completions in [[OwnPropertyKeys]] / [[GetOwnProperty]]
synchronous-thenable remainingElementsCount step-8 edge behavior
additional low-level closure/idempotency stress cases

References

Prior boilerplate PR: #4927
Testing plan issue: #4886
Proposal text: Await Dictionary

Cover shared failure/success behavior for Promise.allKeyed and Promise.allSettledKeyed, including non-object rejection, non-constructor context, key ordering, and allSettled result-shape outcomes.

test/built-ins/Promise/allKeyed/key-order-preserved.js

test/built-ins/Promise/allKeyed/resolves-empty-object.js

test/built-ins/Promise/allKeyed/arg-not-object-reject.js

…nt coverage - Change key-order-preserved settle sequence to 2nd, 3rd, 1st to avoid false passes from reverse-order implementations - Use Reflect.ownKeys instead of Object.keys in empty-object assertions for exhaustive own-key verification - Add separate BigInt rejection tests gated behind BigInt feature flag

- prototype-keys-ignored: inherited enumerable properties are excluded ([[OwnPropertyKeys]] returns only own keys) - symbol-keys: enumerable symbol-keyed properties are included in the result alongside string keys - arg-is-function: functions with enumerable own properties are accepted as valid object arguments; built-in non-enumerable properties excluded

ptomato

Thanks! Just a few minor comments.

For future reference, the tests are more readable when using async helpers. (And would avoid the $DONE called twice situation) No need to go back and change these unless you really want to, though.

test/built-ins/Promise/allKeyed/resolve-not-callable-reject-with-typeerror.js

test/built-ins/Promise/allKeyed/arg-not-object-reject.js

- Adopt asyncHelpers.js across all 23 async test files - Replace manual .then($DONE, $DONE) with asyncTest wrapper - Convert TypeError rejection tests to assert.throwsAsync for more robust error checking - Fixes double-$DONE bug in resolve-not-callable-reject-with-typeerror

danialasaria · 2026-04-02T20:14:51Z

Thanks for the review @ptomato! Converted all async tests to use asyncTest / assert.throwsAsync from asyncHelpers.js -- fixes the double-$DONE issue and should be easier to read going forward. null and undefined should have been already covered in the chain (lines 28-29).

acutmore · 2026-04-03T11:54:44Z

test/built-ins/Promise/allKeyed/reject-immed.js

@@ -0,0 +1,36 @@
+// Copyright (C) 2026 Danial Asaria (Bloomberg LP). All rights reserved.


was this file supposed to be named reject-immediately?

Either one works for me, we usually don't sweat the filenames too much as long as they are descriptive (and not spec references like "13.1.9.step5.js" or "fail-RequireInternalSlot-step2.js")

Im happy either way too. Mostly just checking it wasn't a typo.

Not a typo! Went with the shorter form, but happy to rename if there's a preference.

acutmore · 2026-04-03T11:57:55Z

test/built-ins/Promise/allSettledKeyed/symbol-keys.js

+
+var sym = Symbol('s');
+var input = { str: Promise.resolve(1) };
+input[sym] = Promise.resolve(2);


I think it would be good to also have a non-enumerable symbol. Then we've covered all 4 combinations of string/symbols and enumerable/non-enumerable.

Good idea--added a non-enumerable symbol to both symbol-keys.js files so we cover all 4 cases.

ptomato

👍, thanks!

We can merge after addressing Ashley's comment, or merge now and leave it for a followup, whatever you prefer.

Covers all 4 combinations of string/symbol and enumerable/non-enumerable.

danialasaria · 2026-04-07T17:12:20Z

👍, thanks!

We can merge after addressing Ashley's comment, or merge now and leave it for a followup, whatever you prefer.

Addressed! Should be good to merge now

ptomato added the needs review label Feb 18, 2026

[await-dictionary] add runtime keyed Promise combinator tests

50702d4

Cover shared failure/success behavior for Promise.allKeyed and Promise.allSettledKeyed, including non-object rejection, non-constructor context, key ordering, and allSettled result-shape outcomes.

danialasaria force-pushed the dasaria/await-dictionary-keyed-runtime-tests branch from d6a6c31 to 50702d4 Compare February 23, 2026 16:22

acutmore reviewed Feb 24, 2026

View reviewed changes

test/built-ins/Promise/allKeyed/key-order-preserved.js Outdated Show resolved Hide resolved

test/built-ins/Promise/allKeyed/resolves-empty-object.js Outdated Show resolved Hide resolved

test/built-ins/Promise/allKeyed/arg-not-object-reject.js Outdated Show resolved Hide resolved

danialasaria force-pushed the dasaria/await-dictionary-keyed-runtime-tests branch from 607531a to 589f4da Compare February 26, 2026 19:20

danialasaria requested a review from acutmore February 26, 2026 19:28

acutmore approved these changes Feb 26, 2026

View reviewed changes

danialasaria marked this pull request as ready for review March 2, 2026 17:00

danialasaria requested a review from a team as a code owner March 2, 2026 17:00

danialasaria marked this pull request as draft March 4, 2026 18:31

danialasaria force-pushed the dasaria/await-dictionary-keyed-runtime-tests branch from fd62c35 to 6c64e5d Compare March 4, 2026 19:04

acutmore approved these changes Mar 4, 2026

View reviewed changes

danialasaria marked this pull request as ready for review March 4, 2026 19:30

ptomato approved these changes Apr 1, 2026

View reviewed changes

test/built-ins/Promise/allKeyed/resolve-not-callable-reject-with-typeerror.js Outdated Show resolved Hide resolved

test/built-ins/Promise/allKeyed/arg-not-object-reject.js Outdated Show resolved Hide resolved

danialasaria force-pushed the dasaria/await-dictionary-keyed-runtime-tests branch from 6d6ab23 to 89ed7e3 Compare April 2, 2026 20:10

Merge branch 'main' into dasaria/await-dictionary-keyed-runtime-tests

5b75df8

acutmore reviewed Apr 3, 2026

View reviewed changes

ptomato approved these changes Apr 6, 2026

View reviewed changes

add non-enumerable symbol key to symbol-keys tests

759a136

Covers all 4 combinations of string/symbol and enumerable/non-enumerable.

ptomato merged commit b9a76eb into tc39:main Apr 7, 2026
14 checks passed

		@@ -0,0 +1,36 @@
		// Copyright (C) 2026 Danial Asaria (Bloomberg LP). All rights reserved.

Conversation

danialasaria commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What this PR covers

Shared coverage for both methods

Promise.allKeyed-specific

Promise.allSettledKeyed-specific

Notes

What this PR does not cover

References

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptomato left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

danialasaria commented Apr 2, 2026

Uh oh!

acutmore Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

ptomato Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

acutmore Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

danialasaria Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

acutmore Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

danialasaria Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ptomato left a comment

Choose a reason for hiding this comment

Uh oh!

danialasaria commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danialasaria commented Feb 18, 2026 •

edited

Loading

`Promise.allKeyed`-specific

`Promise.allSettledKeyed`-specific

danialasaria Apr 7, 2026 •

edited

Loading