Skip to content

[Temporal] Expand daysInMonth test coverage for Hebrew calendar #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptomato merged 2 commits into from
Dec 5, 2025
Merged

[Temporal] Expand daysInMonth test coverage for Hebrew calendar #4764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a52111
[Temporal] Expand daysInMonth test coverage for Hebrew calendar
catamorphism Dec 4, 2025
e029a94
Update PlainYearMonth test
catamorphism Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 64 additions & 2 deletions test/intl402/Temporal/PlainDate/prototype/daysInMonth/basic-hebrew.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ const calendar = "hebrew";
const options = { overflow: "reject" };

// 5732 = ISO year 1972
// 5732 is a common year; 5730 is a leap year

const sampleYears = {
// Deficient leap year
5730: [
30,
29,
Expand All @@ -29,6 +29,7 @@ const sampleYears = {
30,
29,
],
// Complete common year
5732: [
30,
30,
Expand All @@ -42,8 +43,69 @@ const sampleYears = {
29,
30,
29,
],
// Regular common year
5778: [
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Complete leap year
5779: [
30,
30,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Deficient common year
5781: [
30,
29,
29,
29,
30,
29,
30,
29,
30,
29,
]
30,
29,
],
// Regular leap year
5782: [
30,
29,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
};

for (var [year, daysInMonth] of Object.entries(sampleYears)) {
Expand Down
66 changes: 64 additions & 2 deletions test/intl402/Temporal/PlainDateTime/prototype/daysInMonth/basic-hebrew.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ const calendar = "hebrew";
const options = { overflow: "reject" };

// 5732 = ISO year 1972
// 5732 is a common year; 5730 is a leap year

const sampleYears = {
// Deficient leap year
5730: [
30,
29,
Expand All @@ -29,6 +29,7 @@ const sampleYears = {
30,
29,
],
// Complete common year
5732: [
30,
30,
Expand All @@ -42,8 +43,69 @@ const sampleYears = {
29,
30,
29,
],
// Regular common year
5778: [
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Complete leap year
5779: [
30,
30,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Deficient common year
5781: [
30,
29,
29,
29,
30,
29,
30,
29,
30,
29,
]
30,
29,
],
// Regular leap year
5782: [
30,
29,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
};

for (var [year, daysInMonth] of Object.entries(sampleYears)) {
Expand Down
66 changes: 64 additions & 2 deletions test/intl402/Temporal/PlainYearMonth/prototype/daysInMonth/basic-hebrew.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ const calendar = "hebrew";
const options = { overflow: "reject" };

// 5732 = ISO year 1972
// 5732 is a common year; 5730 is a leap year

const sampleYears = {
// Deficient leap year
5730: [
30,
29,
Expand All @@ -29,6 +29,7 @@ const sampleYears = {
30,
29,
],
// Complete common year
5732: [
30,
30,
Expand All @@ -42,8 +43,69 @@ const sampleYears = {
29,
30,
29,
],
// Regular common year
5778: [
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Complete leap year
5779: [
30,
30,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Deficient common year
5781: [
30,
29,
29,
29,
30,
29,
30,
29,
30,
29,
]
30,
29,
],
// Regular leap year
5782: [
30,
29,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
};

for (var [year, daysInMonth] of Object.entries(sampleYears)) {
Expand Down
66 changes: 64 additions & 2 deletions test/intl402/Temporal/ZonedDateTime/prototype/daysInMonth/basic-hebrew.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ const calendar = "hebrew";
const options = { overflow: "reject" };

// 5732 = ISO year 1972
// 5732 is a common year; 5730 is a leap year

const sampleYears = {
// Deficient leap year
5730: [
30,
29,
Expand All @@ -29,6 +29,7 @@ const sampleYears = {
30,
29,
],
// Complete common year
5732: [
30,
30,
Expand All @@ -42,8 +43,69 @@ const sampleYears = {
29,
30,
29,
],
// Regular common year
5778: [
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Complete leap year
5779: [
30,
30,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
// Deficient common year
5781: [
30,
29,
29,
29,
30,
29,
30,
29,
30,
29,
]
30,
29,
],
// Regular leap year
5782: [
30,
29,
30,
29,
30,
30,
29,
30,
29,
30,
29,
30,
29,
],
};

for (var [year, daysInMonth] of Object.entries(sampleYears)) {
Expand Down