[Temporal] Add test coverage for offset string of the form +00:0000#4763
Merged
[Temporal] Add test coverage for offset string of the form +00:0000#4763
Conversation
fabon-f
reviewed
Dec 4, 2025
ptomato
requested changes
Dec 5, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Looks good, but to cover all points where these strings might be parsed, I think we need tests for the relativeTo parameter in Temporal.Duration.compare, Temporal.Duration.prototype.round, and Temporal.Duration.prototype.total. Both for ZonedDateTime strings and ZonedDateTime property bags with an offset property.
Contributor
Author
|
ptomato
approved these changes
Dec 11, 2025
This string shouldn't parse (+00:00:00 or +000000 would be valid). Add tests for date/time strings containing this offset for Instant, PlainDateTime, PlainTime, and ZonedDateTime. Also add a test for ZonedDateTime taking this offset in a property bag.
ptomato
force-pushed
the
sub-minute-precision
branch
from
fe8537b to
390ac2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This string shouldn't parse (+00:00:00 or +000000 would be valid).
Add tests for date/time strings containing this offset for Instant, PlainDateTime, PlainTime, and ZonedDateTime. Also add a test for ZonedDateTime taking this offset in a property bag.