Intl era monthcode: PlainYearMonth tests, part 1#4762
Merged
Conversation
Ms2ger
approved these changes
Dec 4, 2025
There are cases where we don't care exactly what the PlainYearMonth's ISO reference day is, just that it is consistent with PlainDate. To enable writing tests for this, add a feature to TemporalHelpers.assertPlainYearMonth() where you can pass null as the referenceISODay argument, and it will be checked for consistency with PlainDate but not asserted to be any particular value. I considered making this the default argument, but the default argument was already 1, which is valuable for calendars that are ISO-like, and I didn't want to have to go back and change all callers.
This commit copies all of the PlainDate.from tests that would apply to PlainYearMonth, and adapts them where necessary.
…th.daysInMonth This commit copies all of the PlainDate.prototype.daysInMonth tests that would apply to PlainYearMonth, and adapts them where necessary.
This commit copies all of the PlainDate.prototype.with tests that would apply to PlainYearMonth, and adapts them where necessary.
ptomato
force-pushed
the
intl-era-monthcode-plainyearmonth-part1
branch
from
f92e311 to
695015b
Compare
This was referenced Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part 1 of a series that will copy all of the PlainDate tests that would apply to PlainYearMonth, and adapt them where necessary.
This covers
from(),with(), anddaysInMonth. To follow:since(),until(),add(),subtract().It's very large so most likely the best way to review it is spot-checking and searching for extraneous
day:properties. And of course pay attention to the harness file change.