Repository navigation
feat(http): app-defined request identity and shared cookie jar (fix #3687 - #3703
Open
lucasfernog wants to merge 2 commits into
Open
lucasfernog wants to merge 2 commits into
lucasfernog wants to merge 2 commits into
Conversation
…3687) - `userAgent` and `requestHeaders` config options to set or remove headers (e.g. Origin) per URL pattern - `Builder` with the same options plus an `on_request` hook - `HttpExt::http().cookie_jar()` exposes the jar to native reqwest clients - unit tests, plus e2e coverage through the api example
FabianLars
reviewed
Oct 12, 2026
Comment on lines
+111
to
+113
| pub fn cookie_jar(&self) -> std::sync::Arc<CookieJar> { | ||
| self.cookies_jar.clone() | ||
| } |
Member
There was a problem hiding this comment.
we removed reqwest from the public api and add reqwest_cookie_store which is also 0.x ? mark it as unstable or something then.
Member
Author
There was a problem hiding this comment.
well in this case we have inlined reqwest_cookie_store in the plugin as a submodule
FabianLars
reviewed
Oct 12, 2026
| /// | ||
| /// The error is serialized to the frontend as its [`Display`](std::fmt::Display) string. | ||
| #[derive(Debug, thiserror::Error)] | ||
| #[non_exhaustive] |
Member
There was a problem hiding this comment.
technically breaking change but maybe fine since it's not used anywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
userAgentandrequestHeadersconfig options to set or remove headers (e.g. Origin) per URL patternBuilderwith the same options plus anon_requesthookHttpExt::http().cookie_jar()exposes the jar to native reqwest clients