Repository navigation
fix(fs): reject negative offsets when seeking from the start - #3633
Conversation
In plugins/fs/src/commands.rs seek, `SeekFrom::Start(offset as u64)` turned -1 into u64::MAX. The offset is now converted with u64::try_from and a negative one is an error. E2E spec added.
a662a13 to
cc45b3b
Compare
Package Changes Through cc45b3bThere are 57 changes which include autostart with patch, deep-link with patch, fs with patch, fs-js with patch, haptics with patch, geolocation with patch, haptics-js with patch, geolocation-js with patch, notification with patch, notification-js with patch, autostart-js with patch, barcode-scanner with patch, barcode-scanner-js with patch, biometric with patch, biometric-js with patch, cli with patch, cli-js with patch, clipboard-manager with patch, clipboard-manager-js with patch, deep-link-js with patch, dialog with patch, dialog-js with patch, global-shortcut with patch, global-shortcut-js with patch, http with patch, http-js with patch, log with patch, log-js with patch, nfc with patch, nfc-js with patch, opener with patch, opener-js with patch, os with patch, os-js with patch, positioner with patch, positioner-js with patch, process with patch, process-js with patch, shell with patch, shell-js with patch, sql with patch, sql-js with patch, store with patch, store-js with patch, stronghold with patch, stronghold-js with patch, updater with patch, updater-js with patch, upload with patch, upload-js with patch, websocket with patch, websocket-js with patch, window-state with patch, window-state-js with patch, localhost with patch, persisted-scope with patch, single-instance with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
In plugins/fs/src/commands.rs seek,
SeekFrom::Start(offset as u64)turned -1 into u64::MAX. The offset is now converted with u64::try_from and a negative one is an error. E2E spec added.