Skip to content

fix(fs): reject negative offsets when seeking from the start - #3633

Merged
lucasfernog merged 1 commit into
tauri-apps:v2from
lucasfernog:fix/fs-seek-negative
Oct 9, 2026
Merged

lucasfernog merged 1 commit into
tauri-apps:v2from
lucasfernog:fix/fs-seek-negative

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

In plugins/fs/src/commands.rs seek, SeekFrom::Start(offset as u64) turned -1 into u64::MAX. The offset is now converted with u64::try_from and a negative one is an error. E2E spec added.

In plugins/fs/src/commands.rs seek, `SeekFrom::Start(offset as u64)`
turned -1 into u64::MAX. The offset is now converted with u64::try_from
and a negative one is an error. E2E spec added.
@lucasfernog
lucasfernog requested a review from a team as a code owner September 23, 2026 15:20
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Package Changes Through cc45b3b

There are 57 changes which include autostart with patch, deep-link with patch, fs with patch, fs-js with patch, haptics with patch, geolocation with patch, haptics-js with patch, geolocation-js with patch, notification with patch, notification-js with patch, autostart-js with patch, barcode-scanner with patch, barcode-scanner-js with patch, biometric with patch, biometric-js with patch, cli with patch, cli-js with patch, clipboard-manager with patch, clipboard-manager-js with patch, deep-link-js with patch, dialog with patch, dialog-js with patch, global-shortcut with patch, global-shortcut-js with patch, http with patch, http-js with patch, log with patch, log-js with patch, nfc with patch, nfc-js with patch, opener with patch, opener-js with patch, os with patch, os-js with patch, positioner with patch, positioner-js with patch, process with patch, process-js with patch, shell with patch, shell-js with patch, sql with patch, sql-js with patch, store with patch, store-js with patch, stronghold with patch, stronghold-js with patch, updater with patch, updater-js with patch, upload with patch, upload-js with patch, websocket with patch, websocket-js with patch, window-state with patch, window-state-js with patch, localhost with patch, persisted-scope with patch, single-instance with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.49 2.0.50
api-example-js 2.0.45 2.0.46
deep-link-example-js 2.2.13 2.2.14
autostart 2.5.1 2.5.2
autostart-js 2.5.1 2.5.2
barcode-scanner 2.4.6 2.4.7
barcode-scanner-js 2.4.6 2.4.7
biometric 2.3.3 2.3.4
biometric-js 2.3.3 2.3.4
cli 2.4.1 2.4.2
cli-js 2.4.1 2.4.2
clipboard-manager 2.3.3 2.3.4
clipboard-manager-js 2.3.3 2.3.4
deep-link 2.4.10 2.4.11
deep-link-js 2.4.10 2.4.11
fs 2.5.2 2.5.3
fs-js 2.5.2 2.5.3
dialog 2.7.3 2.7.4
dialog-js 2.7.3 2.7.4
geolocation 2.3.3 2.3.4
geolocation-js 2.3.3 2.3.4
global-shortcut 2.3.2 2.3.3
global-shortcut-js 2.3.2 2.3.3
opener 2.5.5 2.5.6
opener-js 2.5.5 2.5.6
haptics 2.3.3 2.3.4
haptics-js 2.3.3 2.3.4
http 2.7.0 2.7.1
http-js 2.6.1 2.6.2
localhost 2.3.2 2.3.3
log 2.9.2 2.9.3
log-js 2.9.2 2.9.3
nfc 2.3.6 2.3.7
nfc-js 2.3.6 2.3.7
notification 2.4.0 2.4.1
notification-js 2.4.0 2.4.1
os 2.3.2 2.3.3
os-js 2.3.2 2.3.3
persisted-scope 2.3.8 2.3.9
positioner 2.3.4 2.3.5
positioner-js 2.3.4 2.3.5
process 2.3.1 2.3.2
process-js 2.3.1 2.3.2
shell 2.3.6 2.3.7
shell-js 2.3.6 2.3.7
single-instance 2.4.5 2.4.6
sql 2.4.1 2.4.2
sql-js 2.4.1 2.4.2
store 2.4.5 2.4.6
store-js 2.4.5 2.4.6
stronghold 2.3.2 2.3.3
stronghold-js 2.3.2 2.3.3
updater 2.12.0 2.12.1
updater-js 2.12.0 2.12.1
upload 2.4.1 2.4.2
upload-js 2.4.1 2.4.2
websocket 2.4.3 2.4.4
websocket-js 2.4.3 2.4.4
window-state 2.4.1 2.4.2
window-state-js 2.4.1 2.4.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog
lucasfernog merged commit 77d00a4 into tauri-apps:v2 Oct 9, 2026
37 of 40 checks passed
@lucasfernog
lucasfernog deleted the fix/fs-seek-negative branch October 9, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants