Skip to content

fix(barcode-scanner): settle the pending scan() promise on cancel (fix #3560) #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasfernog merged 1 commit into from
Oct 12, 2026
Merged

fix(barcode-scanner): settle the pending scan() promise on cancel (fix #3560) #3571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/barcode-scanner-cancel-settles-scan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"barcode-scanner": patch
"barcode-scanner-js": patch
---

Fix `cancel()` on Android leaving the pending `scan()` promise unsettled: `destroy()` cleared the saved invoke before it was rejected, so the `"cancelled"` rejection never reached the caller. The pending scan is now rejected before the camera is torn down, matching iOS.
4 changes: 3 additions & 1 deletion plugins/barcode-scanner/android/src/main/java/BarcodeScannerPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,10 @@ class BarcodeScannerPlugin(private val activity: Activity) : Plugin(activity),

@Command
fun cancel(invoke: Invoke) {
destroy()
// Reject the pending scan before destroy() clears savedInvoke, otherwise the
// scan() promise is never settled. Mirrors the iOS implementation.
savedInvoke?.reject("cancelled")
destroy()
invoke.resolve()
}

Expand Down
Loading