Repository navigation
Conversation
Package Changes Through 13cd21fThere are 9 changes which include deep-link with patch, deep-link-js with patch, shell with minor, shell-js with minor, single-instance with patch, updater with patch, updater-js with patch, window-state with minor, window-state-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Also, some of your commits are not signed + your seem not to have the signing public key uploaded to GitHub yet.
| } | ||
|
|
||
| if flags.contains(StateFlags::MAXIMIZED) && state.maximized { | ||
| // fullscreen > maximized > minimized |
There was a problem hiding this comment.
These 3 can co-exist.
| } | ||
|
|
||
| if flags.contains(StateFlags::FULLSCREEN) { | ||
| metadata.fullscreen = self.is_fullscreen()?; |
There was a problem hiding this comment.
Don't we already have fullscreen implemented?
| let concern_flags = StateFlags::MAXIMIZED | ||
| | StateFlags::MINIMIZED | ||
| | StateFlags::POSITION | ||
| | StateFlags::SIZE | ||
| | StateFlags::FULLSCREEN; | ||
|
|
||
| let is_concern = flags.intersects(concern_flags); | ||
|
|
||
| let is_maximized = is_concern && self.is_maximized()?; | ||
|
|
||
| let is_minimized = is_concern && self.is_minimized()?; | ||
|
|
||
| let is_fullscreen = is_concern && self.is_fullscreen()?; |
There was a problem hiding this comment.
I don't think this change is correct
- restore maximized and fullscreen independently, set fullscreen from saved state - minimize after show/focus so it is not undone - don't save size/position while fullscreen, query state only for relevant flags - keep the resize handler from overwriting maximized/minimized/fullscreen - exclude MINIMIZED from StateFlags::default() - add MINIMIZED to the JS StateFlags enum - add change file
Add new member
StateFlags::MINIMIZEDto record window.is_minimized() since we have StateFlag::MAXIMIZEDImplement StatesFlags::FULLSCREEN, records & recover its state accordingly