Skip to content

fix(deep-link): check update-desktop-database existence before executing - #3383

Merged
lucasfernog merged 3 commits into
tauri-apps:v2from
mvanhorn:osc/2265-check-update-desktop-database
Oct 16, 2026
Merged

lucasfernog merged 3 commits into
tauri-apps:v2from
mvanhorn:osc/2265-check-update-desktop-database

Conversation

@mvanhorn

@mvanhorn mvanhorn commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Summary

On Linux, update-desktop-database from desktop-file-utils may not be installed. KDE systems don't require it. The current code calls it unconditionally and fails with an IO error when the command is missing.

This changes the call to handle ErrorKind::NotFound gracefully - logs a warning and continues instead of failing. Non-NotFound errors still propagate.

Changes

  • plugins/deep-link/src/lib.rs: Wrap the update-desktop-database invocation in a match that handles NotFound with a warning instead of returning an error.

Testing

  • cargo check -p tauri-plugin-deep-link passes

Fixes #2265

This contribution was developed with AI assistance (Claude Code).

On Linux, `update-desktop-database` (from `desktop-file-utils`) may not
be installed, especially on KDE systems. Instead of failing with an IO
error, log a warning when the command is not found and continue.

Non-NotFound errors still propagate as before.

Fixes tauri-apps#2265
@mvanhorn
mvanhorn requested a review from a team as a code owner April 9, 2026 06:55
@github-actions

github-actions Bot commented Apr 14, 2026 •

Copy link
Copy Markdown
Contributor

Package Changes Through f259fd5

There are 7 changes which include deep-link with patch, deep-link-js with patch, shell with minor, shell-js with minor, single-instance with patch, updater with patch, updater-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.56 2.0.57
api-example-js 2.0.52 2.0.53
deep-link-example-js 2.2.17 2.2.18
deep-link 2.6.2 2.6.3
deep-link-js 2.6.2 2.6.3
shell 2.5.0 2.6.0
shell-js 2.5.0 2.6.0
single-instance 2.5.4 2.5.5
updater 2.14.0 2.14.1
updater-js 2.14.0 2.14.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

lucasfernog
lucasfernog previously approved these changes Oct 16, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​libc@​0.2.179 ⏵ 0.2.1868010093100100

View full report

@lucasfernog
lucasfernog merged commit 8dc878f into tauri-apps:v2 Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug][deep-link] Check the existence of command update-desktop-database before executing

3 participants