Add optional retry-on-timeout handling - #171
Merged
Merged
Conversation
Poyraxx
marked this pull request as ready for review
June 3, 2026 18:55
Member
|
Hi, thanks for the contribution and sorry for the delay in reviewing! I was a bit hesitant to add this initially but given 2 different people have asked for it I guess it's worthwhile. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry_on_timeoutflag to task and cron registrationWhy
Issue #109 points out that worker timeouts currently fail immediately, which makes per-task retry behavior awkward when the built-in timeout is the thing that fires. This keeps the existing default behavior intact while adding an opt-in path for tasks that should retry after a timeout.
Root cause
Worker-enforced timeouts were converted straight into
TimeoutErrorresults, so they never entered the same retry path used byStreaqRetry.Validation
python -m compileall streaq testsCloses #109.