Fix NeoPool SENSOR JSON key: "Module" → "Modules"#1551
Merged
arendst merged 1 commit intotasmota:masterfrom Apr 4, 2026
Merged
Fix NeoPool SENSOR JSON key: "Module" → "Modules"#1551arendst merged 1 commit intotasmota:masterfrom
arendst merged 1 commit intotasmota:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NeoPool SENSOR telemetry JSON uses
"Modules"(plural) as the key name, but the documentation shows"Module"(singular) in the example payload and descriptive text.The Tasmota source code confirms
"Modules"is correct:xsns_83_neopool.inodefinesD_NEOPOOL_JSON_MODULES = "Modules""Modules"This was discussed with @curzon01, who requested the fix here.
Changes (3 lines in
docs/NeoPool.md)Line 137 — SENSOR JSON example:
Line 315 — Description text:
Line 319 — Reference to SENSOR topic: