Conversation
These really should be secret strings, so we can simply emit the settings object for debugging purposes. Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
This requires all extenders of Settings to use Pydantic, though. Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
When the last commit changed the Settings token type to a SecretStr— a change done using GitHub editor without mypy running— I neglected to account for getting the secret value. Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
because I can't output GitHub format and Full format simultaneously? Signed-off-by: Colin Dean <colin.dean@target.com>
The docs don't seem to represent this well: This indicates that failure() will be true if anything fails: https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#failure but I think "continue-on-error" enables failure() to pass on a failure. So we need this explicit check after all, per: https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#failure-with-conditions Signed-off-by: Colin Dean <colindean@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+49
to
+56
| if: | | ||
| ${{ | ||
| failure() | ||
| || steps.rufffmt.conclusion == 'failure' | ||
| || steps.ruffcheck.conclusion == 'failure' | ||
| || steps.mypy.conclusion == 'failure' | ||
| || steps.pytest.conclusion == 'failure' | ||
| }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These really should be secret strings, so we can simply emit the settings object for debugging purposes.