Skip to content

Parse cookies values containing equal sign #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardassan merged 1 commit into from
Jun 10, 2026
Merged

Parse cookies values containing equal sign #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/http/cookie.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ pub const CookieMap = struct {
while (pairs.next()) |pair| {
var kv = std.mem.splitScalar(u8, pair, '=');
const key = kv.next() orelse continue;
const value = kv.next() orelse continue;
if (kv.next() != null) continue;
const value = kv.rest();

const key_dup = try self.allocator.dupe(u8, key);
errdefer self.allocator.free(key_dup);
Expand All @@ -150,9 +149,10 @@ test "Cookie: Header Parsing" {
var cookie_map: CookieMap = .init(testing.allocator);
defer cookie_map.deinit();

try cookie_map.parse_from_header("sessionId=abc123; java=slop");
try cookie_map.parse_from_header("sessionId=abc123; java=slop; foo=bar=baz");
try testing.expectEqualStrings("abc123", cookie_map.get("sessionId").?);
try testing.expectEqualStrings("slop", cookie_map.get("java").?);
try testing.expectEqualStrings("bar=baz", cookie_map.get("foo").?);
}

test "Cookie: Response Formatting" {
Expand Down
Loading