request: switch all request types to value receivers and value returns#584
Open
bigbes wants to merge 1 commit into
Open
request: switch all request types to value receivers and value returns#584bigbes wants to merge 1 commit into
bigbes wants to merge 1 commit into
Conversation
bigbes
force-pushed
the
bigbes/gh-238-request-value-receivers
branch
from
2c647d4 to
be4af03
Compare
oleg-jukovec
force-pushed
the
bigbes/gh-238-request-value-receivers
branch
from
be4af03 to
f3f2647
Compare
oleg-jukovec
requested changes
May 16, 2026
Collaborator
There was a problem hiding this comment.
I've rebased the PR.
But we still have New/Make different naming for value constructors in the connector:
NewFooReuqest, but MakeDatetime.
It is a bit confusing. I've suggest to rename all request constructors to MakeFooRequest OR to rename all value constructor to NewFoo.
All New*Request() constructors now return values instead of pointers. All methods on request types use value receivers and return values, enabling immutable builder-style chaining. Renamed all value constructors from Make* to New* for naming consistency across the connector: crud.Make*Request → crud.New*Request, datetime.MakeDatetime → datetime.NewDatetime, decimal.MakeDecimal / MakeDecimalFromString / MustMakeDecimal → decimal.NewDecimal / NewDecimalFromString / MustNewDecimal, arrow.MakeArrow → arrow.NewArrow, crud.MakeResult → crud.NewResult. Removed intermediate spaceRequest, spaceIndexRequest types from the tarantool package and spaceRequest from the crud package — space and index fields are inlined directly into each request struct. Converted all constructors to composite literal style. Applied the same pattern to arrow/ and settings/ packages. In the box/ subpackage, request types no longer embed tarantool.CallRequest. They store it as a private field via baseCallRequest and implement their own Context() method returning the wrapper type. Part of #238
bigbes
force-pushed
the
bigbes/gh-238-request-value-receivers
branch
from
f3f2647 to
42cbf81
Compare
Collaborator
Author
|
Fixed, ty! |
oleg-jukovec
requested changes
May 25, 2026
| ```Go | ||
| // Before (pointer receivers, mutation in place): | ||
| req := NewSelectRequest("space") | ||
| req.Index("idx") // mutated req directly |
Collaborator
There was a problem hiding this comment.
Suggested change
| req.Index("idx") // mutated req directly | |
| req.Index("idx") // Mutated req directly. |
|
|
||
| // After (value receivers, must use return value): | ||
| req := NewSelectRequest("space") | ||
| req = req.Index("idx") // must reassign |
Collaborator
There was a problem hiding this comment.
etc
Suggested change
| req = req.Index("idx") // must reassign | |
| req = req.Index("idx") // Must reassign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make*Requests()toNew*Requests(), same for the type constructors.New*Request()constructors now return values instead of pointers; all methods use value receivers and return values, enabling immutable builder-style chaining.spaceRequest/spaceIndexRequesttypes from thetarantoolpackage andspaceRequestfromcrud—spaceandindexfields are inlined directly into each request struct. Constructors converted to composite literal style.arrow/andsettings/. Inbox/, request types no longer embedtarantool.CallRequest— they store it viabaseCallRequestand implement their ownContext()returning the wrapper type.MIGRATION.mdandCHANGELOG.mdfor the full migration guide and breaking-change note (calling a builder method without using the return value silently discards the change).Replaces #553, which was rebased onto current master and renamed to
bigbes/gh-238-request-value-receivers.Part of #238