This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Make ngToast compatible with amd-named & commonjs bundlers - #84
Open
leigh-johnson wants to merge 1 commit into
Open
Make ngToast compatible with amd-named & commonjs bundlers#84leigh-johnson wants to merge 1 commit into
leigh-johnson wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR! ..How does this intervene with #83? Wouldn't make more sense if it was exporting the module name instead of its contents? |
|
Any ETA on this PR being merged? |
|
@tameraydin index.js exports the module name. Can we merge and release this, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to allow AMD-named & CommonJS bundlers like Browserify, RequireJS, Webpack to roll up ngToast. Without this, bundlers have to have to shim ngToast's dependencies and export the module's contents explicitly.