Skip to content

Little kubectl improvements #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DonnerWolfBach wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Little kubectl improvements #2227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fab8e5
added more kubectl objects
DonnerWolfBach Jun 16, 2026
56b2610
added kubernetes output formatting
DonnerWolfBach Jun 16, 2026
0b156c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 16, 2026
d571965
Merge branch 'main' into little_kubectl_improvements
nriley Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/kubectl/kubectl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,9 @@
"deployments",
"replicasets",
"daemonsets",
"configmaps",
"secrets",
)

mod.list("kubectl_output_format_object", desc="-o parameters, so output formatters")
ctx.lists["self.kubectl_output_format_object"] = ("yaml", "wide")

@FireChickenProductivity FireChickenProductivity Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in https://github.com/talonhub/community/blob/main/CONTRIBUTING.md#coding-principles P05, we typically implement lists in .talon-list files unless we have a good reason to do otherwise to make it easier for users to customize. Some users might want to change the spoken forms. Would you mind migrating this to a .talon-list and either migrating the preexisting list or filing an issue for that?

@DonnerWolfBach DonnerWolfBach Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do when I have some time.

5 changes: 4 additions & 1 deletion apps/kubectl/kubectl.talon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,12 @@ cube help: "kubectl help "
cube plugin: "kubectl plugin "
cube version: "kubectl version "

cube {user.kubectl_action} [{user.kubectl_object}]:
cube {user.kubectl_action} [{user.kubectl_object}] [{user.kubectl_output_format_object}]:

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict output formats to commands that support them

Because the optional output format is attached to the generic {user.kubectl_action} rule, phrases such as “cube describe pods yaml” now emit kubectl describe pods -o yaml. Checked the generated Kubernetes kubectl docs: kubectl get explicitly supports (-o|--output=)... output formats, while kubectl describe's synopsis/options list no output flag (https://kubernetes.io/docs/reference/kubectl/generated/kubectl_get/ and https://kubernetes.io/docs/reference/kubectl/generated/kubectl_describe/). This makes valid-sounding describe/delete/label voice commands generate unsupported kubectl invocations; the formatter should be limited to get or to actions/formats that actually support it.

Useful? React with 👍 / 👎.

@DonnerWolfBach DonnerWolfBach Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct. Suggest a fix

@DonnerWolfBach DonnerWolfBach Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex suggest a fix

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use Codex here, create a Codex account and connect to github.

@DonnerWolfBach DonnerWolfBach Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that git does not do such sanity checks to. I would say unless there is found a very nice way to do this, to not do the sanity check

@DonnerWolfBach DonnerWolfBach Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the git integration also has this problem I would suggest accepting that until a nice solutions becomes clear

@nriley nriley Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the community backlog session — agree that it's not necessary to filter this out unless you find an elegant way to do so.

insert("kubectl {kubectl_action} ")
insert(kubectl_object or "")
# requires beta:

@FireChickenProductivity FireChickenProductivity Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to not require beta? You could implement this command with an action instead doing the if statement in Python. You could also try using the or syntax, as is done in line 62 of this file.

Example of or from the wiki:

# Saying "defaultable plex" inserts "x", saying "defaultable" inserts "default"
defaultable [<user.letter>]:
    insert(letter or "default")

@nriley nriley Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the community backlog session — right now we do not require the beta for any functionality. This should be easy enough to fix!

if kubectl_output_format_object: insert(" -o {kubectl_output_format_object}")
insert(" ")

cube detach:
key("ctrl-p")
Expand Down