Support escaping snippet spaces#2223
Draft
FireChickenProductivity wants to merge 13 commits into
Draft
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nriley
requested changes
Jun 27, 2026
Comment on lines
+285
to
+290
| # treat double backslash as escaped backslash | ||
| # treat backslash space as space | ||
| matches = [m for m in re.finditer(ESCAPED_SPACE_EXPRESSION, body)] | ||
| for match in reversed(matches): | ||
| body = body[: match.end() - 1] + body[match.end() :] | ||
| return body.replace("\\\\", "\\") |
Collaborator
There was a problem hiding this comment.
From the community backlog session — consider replacing this with a couple string replacements that replace the escaped backslash with a rarely used/non-printable Unicode character. If this character is in use in the snippet, it is fine to reject it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.