Add capability to focus window by title#1262
Conversation
#Problem When an app has multiple windows focus just picks the first one it fights, which may not be the desired one, and there is not a great way to focus just the window you want. #Solution Add a new method, switcher_focus_app_title, to app_switcher.py that will focus the window whose title matches a given app name and a given regular expression. Also added a command to that will focus a window with a given spoken phrase. #Testing Verified working in current windows eleven environment.
for more information, see https://pre-commit.ci
| and window.title != "" | ||
| ): | ||
| # logging.warn(f'Checking Window: "{window.app.name}" window:"{window.title}" hidden: "{window.hidden}"') | ||
| if regex is None or re.search(regex, window.title): |
There was a problem hiding this comment.
What's your usecase for passing a regex here?
There was a problem hiding this comment.
I currently have two commands that utilize an actual regex vs a plain string.
-
Where the app title could contain one of two different things.
focus outlook: user.switcher_focus_app_title("Outlook", "(Inbox|Calendar)") -
When I don't want the title to contain a specific string.
focus studio: user.switcher_focus_app_title("Microsoft Visual Studio", "^(?:(?!Application Management).)*$")
There was a problem hiding this comment.
I think this seems reasonable given the use cases. @auscompgeek any objection or you think it's ok?
There was a problem hiding this comment.
I suppose the use-case makes sense. I'm not sure we should make this the primary way, or indeed the only way, of focusing by title, as it'd be prone to user error – it's unclear from the action name that it takes a regex.
|
Continuing to go through old pull requests: |
|
From the community backlog session — we agreed that this seems like a useful feature to add to community but we would prefer that it's implemented in terms of dynamic lists as @knausj85 recommended. |
nriley
added
help wanted
|
Pretty sure aegis recently(ish) said in slack he doesn't want community using dynamic lists atm as they are in beta only? Discussion was related to someone wanting my justfile stuff added to community. I'd personally be okay to see community use dynamic lists gated behind a beta flag, but will let someone else have that debate. I believe in that justfile discussion (or around the same time) it was noted you can detect beta programmatically, but then of course still need to maintain two versions of the logic until it hits public. |
|
My comment here was wrong, dynamic lists are not in public. I was confused because the method was defined but trying to use it results in an error. On 0.4.0: >>> from talon import Context
>>> x = Context()
>>> x.dynamic_list
<bound method Context.dynamic_list of Context(repl)>
>>> x.dynamic_list('user.foo')
Traceback (most recent call last):
File "<console>", line 1, in <module>
File "talon/scripting/context.py", line 464, in dynamic_list
NotImplementedError |
|
you shouldn't detect beta, because there are more branches than just beta and public |
Could be I'm confused, but my justfile doesn't use selection list (?) and was the topic of the discussion, and iirc no public release since, so maybe @lunixbochs can confirm. |
6 participants
Problem
When an app has multiple windows focus just picks the first one it fights, which may not be the desired one, and there is not a great way to focus just the window you want.
Solution
Add a new method, switcher_focus_app_title, to app_switcher.py that will focus the window whose title matches a given app name and a given regular expression. Also added a command to that will focus a window with a given spoken phrase.
Testing
Verified working in current windows eleven environment.