streamlocal: resolve symlink directories when checking unix socket paths - #12
Merged
Merged
Conversation
This change follows up on commit 90d7dcb to also cover potential symlink directories in reverse socket forwarding. This is done by adding a new `validateAndResolveListenPath`, this is different from `validateAndResolveSocketPath` as it must validate to the directory level (socket file may not exist). Updates tailscale/corp#41997 Signed-off-by: Mike Jensen <mikej@tailscale.com>
patrickod
approved these changes
Jul 15, 2026
patrickod
pushed a commit
to tailscale/tailscale
that referenced
this pull request
Jul 16, 2026
Updates tailscale/corp#41997 Change-Id: I5fb3d4705766deb71abd0b79a186e99e86be0b15 Signed-off-by: Mike Jensen <mikej@tailscale.com>
patrickod
pushed a commit
to tailscale/tailscale
that referenced
this pull request
Jul 16, 2026
Updates tailscale/corp#41997 Change-Id: I5fb3d4705766deb71abd0b79a186e99e86be0b15 Signed-off-by: Mike Jensen <mikej@tailscale.com>
jentfoo
added a commit
to tailscale/tailscale
that referenced
this pull request
Jul 16, 2026
* Update tailscale/gliderssh to pull in tailscale/gliderssh#12 Updates tailscale/corp#41997 Change-Id: I5fb3d4705766deb71abd0b79a186e99e86be0b15 Signed-off-by: Mike Jensen <mikej@tailscale.com> * .github, tstest/natlab/vmtest: replace old VM runner job with natlab tests The "vm" CI job ran a single test (TestRunUbuntu2404 from tstest/integration/vms) on a privileged self-hosted runner. Its coverage is nearly all redundant with the modern natlab vmtest suite, which boots real Ubuntu VMs and already exercises connectivity, kernel TUN, SSH, Taildrop, ACME, and OS DNS integration on GitHub-hosted runners. The two things it tested that natlab didn't are added back as natlab tests so the runner can be decommissioned: TestUbuntuSystemdUnit runs tailscaled via the stock systemd unit that Linux packages ship (cmd/tailscaled/tailscaled.service with tailscaled.defaults as its EnvironmentFile) instead of launching the binary directly, verifying the unit's directives and its Type=notify readiness handshake. TestDNSExtraRecordsSearchDomains verifies that control-plane DNS ExtraRecords and search domains are resolvable through the guest's OS resolver (libc to systemd-resolved to quad-100). Updates #13038 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: I8d0dfb8b8153289e7ca78f3af03dfece9497bfe8 (cherry picked from commit bef2cd8) --------- Signed-off-by: Mike Jensen <mikej@tailscale.com> Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com>
jentfoo
added a commit
to tailscale/tailscale
that referenced
this pull request
Jul 16, 2026
Updates tailscale/corp#41997 Change-Id: I5fb3d4705766deb71abd0b79a186e99e86be0b15 Signed-off-by: Mike Jensen <mikej@tailscale.com>
jentfoo
added a commit
to tailscale/tailscale
that referenced
this pull request
Jul 16, 2026
Updates tailscale/corp#41997 Change-Id: I5fb3d4705766deb71abd0b79a186e99e86be0b15 Signed-off-by: Mike Jensen <mikej@tailscale.com>
eFog-R
pushed a commit
to eFog-R/tailscale
that referenced
this pull request
Aug 3, 2026
…le#20485) Updates tailscale/corp#41997 Change-Id: I5fb3d4705766deb71abd0b79a186e99e86be0b15 Signed-off-by: Mike Jensen <mikej@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change follows up on commit 90d7dcb to also cover potential symlink directories in reverse socket forwarding.
This is done by adding a new
validateAndResolveListenPath, this is different fromvalidateAndResolveSocketPathas it must validate to the directory level (socket file may not exist).Updates tailscale/corp#41997