Skip to content

Enable app tests by default #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnnyshields wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable app tests by default #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9c517
Enable app tests by default
johnnyshields Apr 12, 2023
769c3dc
Merge branch 'master' into enable-app-tests
johnnyshields Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions spec/integration/app_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ def insert_rails_gem_version(cmd)

describe 'Mongoid application tests' do
before(:all) do
unless SpecConfig.instance.app_tests?
skip 'Set APP_TESTS=1 in environment to run application tests'
end

require 'fileutils'
require 'open-uri'
require 'support/child_process_helper'
Expand Down
2 changes: 1 addition & 1 deletion spec/support/spec_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def client_debug?
end

def app_tests?
%w[1 true yes].include?(ENV['APP_TESTS']&.downcase)
%w[0 false no].exclude?(ENV['APP_TESTS']&.downcase)
end

def ci?
Expand Down