Add source reader and template repr. - #163
Merged
davepeck merged 5 commits intoAug 25, 2026
Merged
Conversation
Contributor
Author
|
@davepeck Almost to the parser exceptions. It is amazing how much code and "shoehorning" all these details take. |
davepeck
reviewed
Aug 24, 2026
davepeck
left a comment
Contributor
There was a problem hiding this comment.
Awesome, thanks @ianjosephwilson!
Some comments here to consider but overall a nice narrow slice.
PS: I merged in #162 and updated the tests in this PR to use the new coordinates.
Contributor
|
@ianjosephwilson Looks good to me. LMK if you're ready for a merge. Thanks! |
Contributor
Author
|
@davepeck Should be ready to merge. I'll go back over the coverage at the end because some of these small methods we might just remove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceReaderclass.MutableLinePositionclass.interpolation_repr(),template_repr_iter()andtemplate_repr()functions.SourceReader.This code is sort of disconnected until we add in the actual exception/error handling.
I was able to sub out the slicing concept for the
TemplateSpan().extract()pretty easily but other parts might changerefforspanbut I'm not sure until we add the next chunk.