Fix for issue #1339: simulating with 'times' conflicted with simulations without. - #1340
Merged
Conversation
…ons without. Extensive fix: changed the interface for SimulateOptions so that you now set the member variables with setters and getters, so that it's now impossible to have internally-inconsistent values: if you set 'times', the start/end/duration values are cleared, and visa versa. This in turn required many changes, and should not only fix the bug, but not allow similar bugs in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensive fix: changed the interface for SimulateOptions so that you now set the member variables with setters and getters, so that it's now impossible to have internally-inconsistent values: if you set 'times', the start/end/duration values are cleared, and visa versa.
This in turn required many changes, and should not only fix the bug, but not allow similar bugs in the future.