Skip to content

Release 2.3.2#627

Closed
pwltr wants to merge 4 commits into
masterfrom
release-2.3.2
Closed

Release 2.3.2#627
pwltr wants to merge 4 commits into
masterfrom
release-2.3.2

Conversation

@pwltr

@pwltr pwltr commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

The purpose of this PR is only to run the e2e suite.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown

Greptile Summary

This PR prepares the 2.3.2 release and updates Lightning probe reporting. The main changes are:

  • Bumped app and extension versions to 2.3.2 build 193.
  • Upgraded ldk-node to 0.7.0-rc.53.
  • Added Lightning scoring fee parameters during node setup.
  • Threaded probe routeFeeMsat through event handling and the probing tool UI.
  • Added 2.3.2 changelog entries.

Confidence Score: 4/5

The probing tool can drop the fee display for successful invoice probes when the new event fee is missing.

  • Most version, dependency, and event-shape updates are applied consistently.
  • The changed probing tool path removed the invoice fee-estimation fallback.
  • A successful probe with no routeFeeMsat now shows no fee, even though the old path could still compute one.

Bitkit/Views/Settings/ProbingTool/ProbingToolScreen.swift

Important Files Changed

Filename Overview
Bitkit/Services/LightningService.swift Adds scoring fee parameters on node setup and logs the new optional probe route fee from events.
Bitkit/ViewModels/WalletViewModel.swift Stores probe route fees in cached and live probe outcomes and converts failed probe short-channel IDs to strings.
Bitkit/Views/Settings/ProbingTool/ProbingToolScreen.swift Uses the event route fee for probe results and removes the previous invoice fee-estimation fallback.
Bitkit/Views/Settings/ProbingTool/ProbeResult.swift Renames the probe result fee field from estimated sats to route-fee millisats.
Bitkit/Views/Settings/ProbingTool/ProbeResultSectionView.swift Updates the probe result fee label and unit display to route fee in millisats.
Bitkit.xcodeproj/project.pbxproj Bumps app metadata and updates the ldk-node package requirement.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Pins the Swift package resolution to the new ldk-node revision.
CHANGELOG.md Adds the 2.3.2 release notes and updates comparison links.

Reviews (1): Last reviewed commit: "chore: version 2.3.2" | Re-trigger Greptile

success: true,
durationMs: durationMs,
estimatedFeeSats: estimatedFee,
routeFeeMsat: resolved.routeFeeMsat,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Optional Event Fee Hides Result

When an invoice probe succeeds but the event does not include routeFeeMsat, this path now stores nil and the fee row disappears. The old successful invoice path still called estimateRoutingFees, so users can lose the fee display even though the app can still compute an estimate for that invoice.

@piotr-iohk

Copy link
Copy Markdown
Collaborator

@piotr-iohk

Copy link
Copy Markdown
Collaborator

@pwltr pwltr closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants