Release 2.3.2#627
Conversation
* fix: tune lightning probe routing * fix: avoid scorer config startup crash
Greptile SummaryThis PR prepares the 2.3.2 release and updates Lightning probe reporting. The main changes are:
Confidence Score: 4/5The probing tool can drop the fee display for successful invoice probes when the new event fee is missing.
Bitkit/Views/Settings/ProbingTool/ProbingToolScreen.swift
|
| Filename | Overview |
|---|---|
| Bitkit/Services/LightningService.swift | Adds scoring fee parameters on node setup and logs the new optional probe route fee from events. |
| Bitkit/ViewModels/WalletViewModel.swift | Stores probe route fees in cached and live probe outcomes and converts failed probe short-channel IDs to strings. |
| Bitkit/Views/Settings/ProbingTool/ProbingToolScreen.swift | Uses the event route fee for probe results and removes the previous invoice fee-estimation fallback. |
| Bitkit/Views/Settings/ProbingTool/ProbeResult.swift | Renames the probe result fee field from estimated sats to route-fee millisats. |
| Bitkit/Views/Settings/ProbingTool/ProbeResultSectionView.swift | Updates the probe result fee label and unit display to route fee in millisats. |
| Bitkit.xcodeproj/project.pbxproj | Bumps app metadata and updates the ldk-node package requirement. |
| Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Pins the Swift package resolution to the new ldk-node revision. |
| CHANGELOG.md | Adds the 2.3.2 release notes and updates comparison links. |
Reviews (1): Last reviewed commit: "chore: version 2.3.2" | Re-trigger Greptile
| success: true, | ||
| durationMs: durationMs, | ||
| estimatedFeeSats: estimatedFee, | ||
| routeFeeMsat: resolved.routeFeeMsat, |
There was a problem hiding this comment.
Optional Event Fee Hides Result
When an invoice probe succeeds but the event does not include routeFeeMsat, this path now stores nil and the fee row disappears. The old successful invoice path still called estimateRoutingFees, so users can lose the fee display even though the app can still compute an estimate for that invoice.
|
Same as synonymdev/bitkit-android#1076 (comment) |
|
Dispatch passed. https://github.com/synonymdev/bitkit-ios/actions/runs/29350676646 |
The purpose of this PR is only to run the e2e suite.