fix: public payments polish part 1#544
Merged
Merged
Conversation
ben-kaufman
marked this pull request as ready for review
May 6, 2026 15:11
This comment has been minimized.
This comment has been minimized.
ben-kaufman
marked this pull request as draft
May 6, 2026 15:19
This comment has been minimized.
This comment has been minimized.
ben-kaufman
marked this pull request as ready for review
May 6, 2026 16:08
ovitrif
reviewed
May 7, 2026
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed code, LGTM.
Tested:
- send > scan contact QR ❌
- send > paste contact pubky ❌
- send > enter manually > paste contact pubky ✅
- QR > Scan ✅
- QR > Paste ❌
Collaborator
|
Re-tested on device. All routes work as expected now. send > scan contact QR ✅ |
ovitrif
enabled auto-merge
May 7, 2026 16:38
Collaborator
|
Looks like the commits in this PR are not GPG/SSH signed, and branch protection requires signed commits before merge. Could you re-sign the commits @ben-kaufman? |
ben-kaufman
force-pushed
the
codex/fix-public-payments-polish-part1
branch
from
May 8, 2026 14:18
4dd56fa to
c67f220
Compare
Contributor
Author
|
@piotr-iohk updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Includes the non-UI route-not-found fix from #539 and the reviewed Pubky contact scan/paste flows. Missing/disabled UI and UI polishing follow-ups are intentionally excluded.