[Twig] Enhance documentation about is_granted() twig function#22219
Open
lyrixx wants to merge 1 commit intosymfony:6.4from
Open
[Twig] Enhance documentation about is_granted() twig function#22219lyrixx wants to merge 1 commit intosymfony:6.4from
lyrixx wants to merge 1 commit intosymfony:6.4from
Conversation
It's better to call the var `attribute`, because it's the Symfony naming: * https://github.com/symfony/symfony/blob/8.1/src/Symfony/Component/Security/Core/Authorization/AuthorizationCheckerInterface.php#L27 * https://github.com/symfony/symfony/blob/8.1/src/Symfony/Component/Security/Core/Authorization/Voter/Voter.php#L97-L107 And it fixes a typo on the type:https://github.com/symfony/symfony/blob/8.1/src/Symfony/Bridge/Twig/Extension/SecurityExtension.php#L37
Contributor
|
I see your point and it could be nice to use same parameters names for same functions present across several components/bridges... |
Member
Author
|
I think we should rename symfony paramater (in twig bridge), WDYT ? |
Contributor
I agree, looks like a code inconsistency to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better to call the var
attribute, because it's the Symfonynaming:
And it fixes a typo on the
type:https://github.com/symfony/symfony/blob/8.1/src/Symfony/Bridge/Twig/Extension/SecurityExtension.php#L37