Skip to content

Update timeseries with new mdocean features#218

Open
rebeccamccabe wants to merge 423 commits into
timeseriesfrom
main
Open

Update timeseries with new mdocean features#218
rebeccamccabe wants to merge 423 commits into
timeseriesfrom
main

Conversation

@rebeccamccabe

Copy link
Copy Markdown
Collaborator

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@al2588 al2588 marked this pull request as ready for review April 28, 2026 21:23
Copilot AI and others added 28 commits May 6, 2026 13:04
…ex to use resultsRE

Agent-Logs-Url: https://github.com/symbiotic-engineering/MDOcean/sessions/1b9fa653-9a67-4075-8094-47eb36478a2e

Co-authored-by: rebeccamccabe <32020426+rebeccamccabe@users.noreply.github.com>
…-function' into copilot/update-numbers-to-automatic-results
…nto copilot/update-numbers-to-automatic-results
…s, force sat comparison; update calkit.yaml and tex files

Agent-Logs-Url: https://github.com/symbiotic-engineering/MDOcean/sessions/c6551b83-5b86-4dd6-8c03-ae8a9a231d0c

Co-authored-by: rebeccamccabe <32020426+rebeccamccabe@users.noreply.github.com>
Agent-Logs-Url: https://github.com/symbiotic-engineering/MDOcean/sessions/c6551b83-5b86-4dd6-8c03-ae8a9a231d0c

Co-authored-by: rebeccamccabe <32020426+rebeccamccabe@users.noreply.github.com>
…ider conditional formatting and optimization hardcoded numbers.json
Agent-Logs-Url: https://github.com/symbiotic-engineering/MDOcean/sessions/db9bb2b9-66c9-4aa7-be5d-fb9511a67812

Co-authored-by: rebeccamccabe <32020426+rebeccamccabe@users.noreply.github.com>
Agent-Logs-Url: https://github.com/symbiotic-engineering/MDOcean/sessions/86eb0c8b-e9f2-44c2-bd74-80aa96c26e5d

Co-authored-by: rebeccamccabe <32020426+rebeccamccabe@users.noreply.github.com>
…constraints-for-optimization

Optimize `eval_constraint` hot path by removing reshape and minimizing transpose overhead
Copilot AI and others added 23 commits June 15, 2026 22:16
Changed output file format from .fig to .pdf for figures. Removed code related to loading cached tables as they cannot be reconstructed easily.
Co-authored-by: Becca <32020426+rebeccamccabe@users.noreply.github.com>
Co-authored-by: Becca <32020426+rebeccamccabe@users.noreply.github.com>
Removed commented-out steps for pulling with retries from the workflow.
…-avoid-rerun

# Conflicts:
#	.calkit/notebooks/executed/pubs/applied-ocean-research-model/view_figs.ipynb
#	.calkit/notebooks/executed/pubs/renewable-energy-mdo/view_figs.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Comparison.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Constraints.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Cost.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/DampingPlateStructures.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/DescFcns.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/DesignSpaceExploration.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/DesignVars.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/DragIntegral.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/FitOlaya.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/ForceSaturationFigFunc.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/GradientOptimFigFunc.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/HydroCoeffFigFunc.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Meem.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Parameters.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/ParetoFigFunc.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/PtoSweep.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/QPCircles.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/ReadNonMatlabFigs.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/RunSingleFigFunc.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Runtime.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Slamming.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/SparHydro.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/SweepGeoms.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Validation.ipynb
#	.calkit/notebooks/executed/results/fig_notebooks/Wecsim.ipynb
#	dvc.lock
#	pubs/applied-ocean-research-model/numeric-results.tex
#	pubs/renewable-energy-mdo/numeric-results.tex
#	results/Comparison/end.json
#	results/Constraints/end.json
#	results/Cost/end.json
#	results/DampingPlateStructures/end.json
#	results/DescFcns/end.json
#	results/DesignSpaceExploration/end.json
#	results/DesignVars/end.json
#	results/DragIntegral/end.json
#	results/FitOlaya/end.json
#	results/ForceSaturationFigFunc/end.json
#	results/GradientOptimFigFunc/end.json
#	results/HydroCoeffFigFunc/end.json
#	results/Meem/end.json
#	results/Parameters/end.json
#	results/ParetoFigFunc/end.json
#	results/PtoSweep/end.json
#	results/QPCircles/end.json
#	results/ReadNonMatlabFigs/end.json
#	results/RunSingleFigFunc/end.json
#	results/Runtime/end.json
#	results/Slamming/end.json
#	results/SparHydro/end.json
#	results/SweepGeoms/end.json
#	results/Validation/end.json
#	results/Wecsim/end.json
…-rerun

Prevent postpro from rerunning during tests if stage not stale. Makes some tests fail that otherwise pass - those that rely on tables being stored and on NonMatlabFigs to have a .fig not just pdf.
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
117 12 105 11
View the full list of 12 ❄️ flaky test(s)
test::validateNominalHydroCoeffs

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 6.6s run time
Verification failed in test/validateNominalHydroCoeffs.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyLessThanOrEqual failed.
    --> Each element must be less than or equal to the maximum value.
        
        Failing Indices:
             1     2     3
    
    Actual Value:
       0.204482267456327   0.887336280522300   0.208933730234385                -Inf
    Maximum Value (Inclusive):
       0.100000000000000
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalHydroCoeffs) at 301
test::validateNominalReport(field_report=c_v,rel_tol_report=0.1_10)

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.33s run time
Verification failed in test/validateNominalReport(field_report=c_v,rel_tol_report=0.1_10).
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyEqual failed.
    --> The numeric values are not equal using "isequaln".
    --> The error was not within relative tolerance.
    --> Failure table:
                 Actual             Expected             Error            RelativeError      RelativeTolerance
            ________________    ________________    ________________    _________________    _________________
                                                                                                              
            86.9438166250446    71.0526622304404    15.8911543946042    0.223653187590149           0.1       
    
    Actual Value:
      86.943816625044647
    Expected Value:
      71.052662230440447
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalReport) at 271
test::validateNominalReportFeasible

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 771s run time
Verification failed in test/validateNominalReportFeasible.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyTrue failed.
    --> The value must evaluate to "true".
    
    Actual Value:
      logical
    
       0
    ----------------------
    Additional Diagnostic:
    ----------------------
    Nominal design violates these constraints: FOS_plate_fatigue, prevent_slamming_operational_79, prevent_slamming_operational_80, prevent_slamming_operational_81, prevent_slamming_operational_91, prevent_slamming_operational_92, prevent_slamming_operational_93, prevent_slamming_operational_94, prevent_slamming_operational_95, prevent_slamming_operational_96, prevent_slamming_operational_103, prevent_slamming_operational_104, prevent_slamming_operational_105, prevent_slamming_operational_106, prevent_slamming_operational_107, prevent_slamming_operational_108, prevent_slamming_operational_109, prevent_slamming_operational_110, prevent_slamming_operational_117, prevent_slamming_operational_118, prevent_slamming_operational_119, prevent_slamming_operational_120, prevent_slamming_operational_121, prevent_slamming_operational_122, prevent_slamming_operational_123, prevent_slamming_operational_124, prevent_slamming_operational_125, prevent_slamming_operational_136, prevent_slamming_operational_137, prevent_slamming_operational_138, prevent_slamming_operational_139
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalReportFeasible) at 291
test::validateNominalWecsim(field_wecsim=J_capex_design,rel_tol_wecsim=0.1_2)

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.0753s run time
Verification failed in test/validateNominalWecsim(field_wecsim=J_capex_design,rel_tol_wecsim=0.1_2).
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyEqual failed.
    --> The numeric values are not equal using "isequaln".
    --> The error was not within relative tolerance.
    --> Failure table:
            Index         Actual         Expected    Error    RelativeError    RelativeTolerance
            _____    ________________    ________    _____    _____________    _________________
                                                                                                
              1      3.45448600796013      NaN        NaN          NaN                0.1       
              2      2.48393320770206      NaN        NaN          NaN                0.1       
              3      2.19948956021416      NaN        NaN          NaN                0.1       
              4      2.12457389854164      NaN        NaN          NaN                0.1       
    
    Actual Value:
       3.454486007960131   2.483933207702065   2.199489560214162   2.124573898541640
    Expected Value:
       NaN   NaN   NaN   NaN
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalWecsim) at 282
test::validateNominalWecsim(field_wecsim=LCOE,rel_tol_wecsim=0.1_1)

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.552s run time
Verification failed in test/validateNominalWecsim(field_wecsim=LCOE,rel_tol_wecsim=0.1_1).
    ----------------
    Test Diagnostic:
    ----------------
    Figure saved to:
    --> .../test-results/aor/2026-06-19_09.11.19/564e9def-b5ac-4d7c-b6da-c3f595a1a8f9/econ_validation_wecsimdfb9ec7f-f312-4d11-b07a-6ce2493cae93.fig
    --> .../test-results/aor/2026-06-19_09.11.19/564e9def-b5ac-4d7c-b6da-c3f595a1a8f9/econ_validation_wecsimdfb9ec7f-f312-4d11-b07a-6ce2493cae93.png
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyEqual failed.
    --> The numeric values are not equal using "isequaln".
    --> The error was not within relative tolerance.
    --> Failure table:
            Index         Actual          Expected    Error    RelativeError    RelativeTolerance
            _____    _________________    ________    _____    _____________    _________________
                                                                                                 
              1      2.85651416182117       NaN        NaN          NaN                0.1       
              2      0.915897367394335      NaN        NaN          NaN                0.1       
              3      0.545496132390269      NaN        NaN          NaN                0.1       
              4      0.469982222865033      NaN        NaN          NaN                0.1       
    
    Actual Value:
       2.856514161821172   0.915897367394335   0.545496132390269   0.469982222865033
    Expected Value:
       NaN   NaN   NaN   NaN
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalWecsim) at 282
test::validateNominalWecsim(field_wecsim=c_v,rel_tol_wecsim=0.1_3)

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.132s run time
Verification failed in test/validateNominalWecsim(field_wecsim=c_v,rel_tol_wecsim=0.1_3).
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyEqual failed.
    --> The numeric values are not equal using "isequaln".
    --> The error was not within relative tolerance.
    --> Failure table:
                 Actual         Expected    Error    RelativeError    RelativeTolerance
            ________________    ________    _____    _____________    _________________
                                                                                       
            66.8511425761024      NaN        NaN          NaN                0.1       
    
    Actual Value:
      66.851142576102362
    Expected Value:
       NaN
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalWecsim) at 282
test::validateNominalWecsim(field_wecsim=power_avg,rel_tol_wecsim=0.1)

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.128s run time
Verification failed in test/validateNominalWecsim(field_wecsim=power_avg,rel_tol_wecsim=0.1).
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyEqual failed.
    --> The numeric values are not equal using "isequaln".
    --> The error was not within relative tolerance.
    --> Failure table:
                 Actual         Expected    Error    RelativeError    RelativeTolerance
            ________________    ________    _____    _____________    _________________
                                                                                       
            135392.022078954      NaN        NaN          NaN                0.1       
    
    Actual Value:
         1.353920220789538e+05
    Expected Value:
       NaN
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalWecsim) at 282
test::validateNominalWecsimFeasible

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.173s run time
Verification failed in test/validateNominalWecsimFeasible.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyTrue failed.
    --> The value must evaluate to "true".
    
    Actual Value:
      logical
    
       0
    ----------------------
    Additional Diagnostic:
    ----------------------
    Nominal design violates these constraints: FOS_plate_fatigue, prevent_slamming_operational_80, prevent_slamming_operational_81, prevent_slamming_operational_92, prevent_slamming_operational_93, prevent_slamming_operational_94, prevent_slamming_operational_95, prevent_slamming_operational_96, prevent_slamming_operational_104, prevent_slamming_operational_105, prevent_slamming_operational_106, prevent_slamming_operational_107, prevent_slamming_operational_108, prevent_slamming_operational_109, prevent_slamming_operational_110, prevent_slamming_operational_116, prevent_slamming_operational_117, prevent_slamming_operational_118, prevent_slamming_operational_119, prevent_slamming_operational_120, prevent_slamming_operational_121, prevent_slamming_operational_122, prevent_slamming_operational_123, prevent_slamming_operational_124, prevent_slamming_operational_125, prevent_slamming_operational_136, prevent_slamming_operational_137, prevent_slamming_operational_138, prevent_slamming_operational_139
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test.m (test.validateNominalWecsimFeasible) at 296
test_dynamics::validateMultibodyReportBaseline

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.0652s run time
Verification failed in test_dynamics/validateMultibodyReportBaseline.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyLessThanOrEqual failed.
    --> Each element must be less than or equal to the maximum value.
        
        Failing Indices:
             1     2     3     4
    
    Actual Value:
      36.494574442233287  27.657557186404567                 NaN                 NaN
    Maximum Value (Inclusive):
         5
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test_dynamics.m (test_dynamics.validateMultibodyReportBaseline) at 76
test_dynamics::validateMultibodyReportTotal

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.0626s run time
Verification failed in test_dynamics/validateMultibodyReportTotal.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyLessThanOrEqual failed.
    --> Each element must be less than or equal to the maximum value.
        
        Failing Indices:
             1     2     3     4
    
    Actual Value:
      65.471094368675381  10.810656387995564                 NaN                 NaN
    Maximum Value (Inclusive):
        10
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test_dynamics.m (test_dynamics.validateMultibodyReportTotal) at 82
test_dynamics::validateSinglebodyWecsimBaseline

Flake rate in main: 100.00% (Passed 0 times, Failed 7 times)

Stack Traces | 502s run time
Verification failed in test_dynamics/validateSinglebodyWecsimBaseline.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyLessThanOrEqual failed.
    --> Each element must be less than or equal to the maximum value.
        
        Failing Indices:
             1     2
    
    Actual Value:
      36.464496303262813  38.534476550366257
    Maximum Value (Inclusive):
         2
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test_dynamics.m (test_dynamics.validateSinglebodyWecsimBaseline) at 52
test_dynamics::validateSinglebodyWecsimTotal

Flake rate in main: 100.00% (Passed 0 times, Failed 7 times)

Stack Traces | 0.0655s run time
Verification failed in test_dynamics/validateSinglebodyWecsimTotal.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyLessThanOrEqual failed.
    --> Each element must be less than or equal to the maximum value.
        
        Failing Indices:
             1
    
    Actual Value:
      12.715966046141702   5.090339861457585
    Maximum Value (Inclusive):
        10
    ------------------
    Stack Information:
    ------------------
    In .../MDOcean/tests/test_dynamics.m (test_dynamics.validateSinglebodyWecsimTotal) at 58

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants