[SwiftSyntaxCodeActions] Move SwiftRefactor code actions in from swift-syntax#2671
Open
25harsh wants to merge 1 commit into
Open
[SwiftSyntaxCodeActions] Move SwiftRefactor code actions in from swift-syntax#267125harsh wants to merge 1 commit into
25harsh wants to merge 1 commit into
Conversation
ahoppen
reviewed
May 27, 2026
Member
ahoppen
left a comment
There was a problem hiding this comment.
Thanks for the PR, @25harsh. I have two requests:
- Could you ensure that each file has a trailing newline and that they pass the swift-format check as described in CONTRIBUTING.md?
- Could you also migrate the tests to SourceKit-LSP. If they need some adjustment, that’s fine. I just don’t want to add the refactoring actions here without test coverage.
0ae609b to
8e8a6ce
Compare
Contributor
Author
|
@ahoppen all changes are done, overloaded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
SyntaxRefactoringProvidertypes mentioned in #2639 out of swift-syntax and intoSources/SwiftSyntaxCodeActions/.Made access specifier changes and dependency changes.
Companion PR #3345
Notes:
Removed compiler(>=6) checks
Ported helpers from
Sources/SwiftRefactor/SyntaxUtils.swifttoSources/SwiftSyntaxCodeActions/SyntaxRefactoringCodeActionProvider.swiftTest cases are yet to be moved.
RemoveSeparatorsFromIntegerLiteral,RemoveRedundantParenthesesandConvertStoredPropertyToComputedneed coverage. (follow-on PRs)Helpers moved
DeclModifierRemover&IntegerLiteralUtilities