chore: remove unconditioned instrument code

[stormslowly]

To check if tracing has a performance cost

Description:

BREAKING CHANGE:

Related issue (if exists):

[changeset-bot]

⚠️ No Changeset found

Latest commit: c15e4df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kdy1]

It has a noticeable cost. You can try enabling tracing/max_level_off

[codspeed-hq]

CodSpeed Performance Report

Merging #11237 will improve performance by 10.2%

_{Comparing stormslowly:chore/try_no_instrument (c15e4df) with main (ee40804)}

Summary

⚡ 21 improvements
✅ 117 untouched

Benchmarks breakdown

	Benchmark	BASE	HEAD	Efficiency
⚡	parse_and_babelify_angular	159.5 ms	144.7 ms	+10.2%
⚡	parse_and_babelify_jquery_mobile	169.5 ms	166.2 ms	+2.02%
⚡	babelify-only	2.1 ms	2 ms	+2.81%
⚡	parse_and_babelify_mootools	72.6 ms	71.1 ms	+2.17%
⚡	parse_and_babelify_yui	67.5 ms	66 ms	+2.23%
⚡	parse_and_babelify_backbone	15.4 ms	15 ms	+2.58%
⚡	parse_and_babelify_jquery	99 ms	97 ms	+2.05%
⚡	parse_and_babelify_underscore	13.2 ms	12.9 ms	+2.55%
⚡	es/target/es2015	1.2 ms	1.2 ms	+4.88%
⚡	es/full-target/es2017	592 µs	579.5 µs	+2.16%
⚡	es/full-target/es2018	555.4 µs	543.1 µs	+2.28%
⚡	es2015_arrow	301.4 µs	294.8 µs	+2.24%
⚡	es/target/es2020	483.6 µs	470.9 µs	+2.7%
⚡	es/full-target/es2016	628.9 µs	616.3 µs	+2.05%
⚡	es2015_block_scoping	457.9 µs	443.4 µs	+3.27%
⚡	es2015_parameters	334.1 µs	324.8 µs	+2.86%
⚡	es/preset-env/usage/builtin_type	231.6 µs	215.8 µs	+7.3%
⚡	es/preset-env/usage/property	109.1 µs	100.7 µs	+8.3%
⚡	es/codegen/with-parser/large	1.1 ms	1.1 ms	+2.11%
⚡	es/codegen/colors	68.4 µs	66.8 µs	+2.42%
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[stormslowly]

In rspack-resolver, when I enable max_level_off and release_max_level_off, I still get 2~15% performance loss in benchmark.

[github-actions]

Binary Sizes

File	Size
swc.linux-x64-gnu.node	31M (31473288 bytes)

Commit: b9f5c70

[kdy1]

I think it's a good idea to remove all tracing code, considering the perf difference

[stormslowly]

According to codspeed's report, the most improved step is enabling max_level_off.
That's quite different from rspack-resolver's case.
I will do some digging to find the season and figure out a way to improve performance and keep trackability.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​swc/​counter@​0.1.3
	jest@​29.7.0 ⏵ 25.5.4	+1		+1
	@​typescript-eslint/​parser@​6.21.0
	@​ast-grep/​napi@​0.3.3
	@​typescript-eslint/​eslint-plugin@​6.21.0
	@​napi-rs/​cli@​3.2.0
	@​octokit/​rest@​18.12.0
	@​antfu/​ni@​0.21.12
	@​actions/​core@​1.10.1

View full report