-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
perf: Disable all unnecessary default-features
#11208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kdy1
wants to merge
38
commits into
main
Choose a base branch
from
kdy1/size-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 35 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b77ebee
default-features = false
kdy1 af53267
lockfile
kdy1 2dc437b
fmt
kdy1 bb7294d
fix
kdy1 ec5f599
clap
kdy1 aa1eaa1
lexical
kdy1 7dfc745
rustc-hash/std
kdy1 e7a3c9c
default features
kdy1 52cfeaf
lexical & syn
kdy1 e65437b
lockfile
kdy1 1a0dee0
lockfile
kdy1 bdfbeb6
feature
kdy1 deb9ea2
codspeed
kdy1 561a4c4
serde-impl
kdy1 6721861
fix flate2
kdy1 54c8fbf
fix
kdy1 441b065
ansi
kdy1 22ee716
once_cell & serde_json
kdy1 f8c7f70
fix
kdy1 bb31861
fix swc crate
kdy1 a41f16a
fix
kdy1 27f51a5
fix jsdoc
kdy1 28ae6f9
fix swc_ecma_codegen
kdy1 fb7f46c
fix swc_ecma_codegen
kdy1 4e6dc83
fix more
kdy1 e62868c
fix hstr
kdy1 99aae2e
hstr
kdy1 a6125d7
swc_trace
kdy1 2c3893d
regex
kdy1 7007d6c
fix regex
kdy1 970df2c
fix
kdy1 36757b4
Merge branch 'main' into kdy1/size-check
github-actions[bot] ca16c96
fix(swc_ecma_compiler): Update dependency versions and add tracing at…
github-actions[bot] e0c916b
fix: Add missing serde std feature for hstr and tracing attributes fo…
github-actions[bot] e5fffc4
fix: Add missing serde std feature for hstr and tracing attributes fo…
github-actions[bot] 0c7f50e
fix: Add missing features required after disabling default-features
github-actions[bot] af2ff3a
fix: Add missing features required after disabling default-features
github-actions[bot] 18aeca8
fix: Add missing base64 std feature and serde-impl for react transforms
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,134 +16,140 @@ repository = "https://github.com/swc-project/swc.git" | |||||
|
|
||||||
| [workspace.dependencies] | ||||||
| # bytecheck version should be in sync with rkyv version. Do not bump individually. | ||||||
| bytecheck = "0.8.0" | ||||||
| rancor = "0.1.0" | ||||||
| rkyv = "0.8.8" | ||||||
|
|
||||||
|
|
||||||
| Inflector = "0.11.4" | ||||||
| allocator-api2 = "0.2.18" | ||||||
| ansi_term = "0.12.1" | ||||||
| anyhow = "1.0.98" | ||||||
| arbitrary = "1" | ||||||
| arrayvec = "0.7.4" | ||||||
| ascii = "1.1.0" | ||||||
| assert_cmd = "2.0.17" | ||||||
| assert_fs = "1.0.13" | ||||||
| auto_impl = "1.2.0" | ||||||
| backtrace = "0.3" | ||||||
| base64 = "0.22.1" | ||||||
| bitflags = "2.5.0" | ||||||
| blake3 = "1.5.4" | ||||||
| browserslist-rs = "0.19.0" | ||||||
| bumpalo = "3.16.0" | ||||||
| bytes-str = "0.2.5" | ||||||
| cargo_metadata = "0.18.1" | ||||||
| changesets = "0.2.2" | ||||||
| chrono = "0.4.38" | ||||||
| codspeed-criterion-compat = "3.0.4" | ||||||
| compact_str = "0.7.1" | ||||||
| console_error_panic_hook = "0.1.7" | ||||||
| copyless = "0.1.5" | ||||||
| crc = "2.1.0" | ||||||
| criterion = "0.5.1" | ||||||
| dashmap = "5.5.3" | ||||||
| dialoguer = "0.10.2" | ||||||
| difference = "2" | ||||||
| dragonbox_ecma = "0.1.0" | ||||||
| either = "1.10.0" | ||||||
| enumset = "1.1.2" | ||||||
| flate2 = "1.0" | ||||||
| getrandom = "0.3.3" | ||||||
| glob = "0.3.0" | ||||||
| bytecheck = { version = "0.8.0", default-features = false } | ||||||
| rancor = { version = "0.1.0", default-features = false } | ||||||
| rkyv = { version = "0.8.8", default-features = false } | ||||||
|
|
||||||
|
|
||||||
| Inflector = { version = "0.11.4", default-features = false } | ||||||
| allocator-api2 = { version = "0.2.18", default-features = false } | ||||||
| ansi_term = { version = "0.12.1", default-features = false } | ||||||
| anyhow = { version = "1.0.98", default-features = false } | ||||||
| arbitrary = { version = "1", default-features = false } | ||||||
| arrayvec = { version = "0.7.4", default-features = false } | ||||||
| ascii = { version = "1.1.0", default-features = false } | ||||||
| assert_cmd = { version = "2.0.17", default-features = false } | ||||||
| assert_fs = { version = "1.0.13", default-features = false } | ||||||
| auto_impl = { version = "1.2.0", default-features = false } | ||||||
| backtrace = { version = "0.3", default-features = false } | ||||||
| base64 = { version = "0.22.1", default-features = false } | ||||||
| bitflags = { version = "2.5.0", default-features = false } | ||||||
| blake3 = { version = "1.5.4", default-features = false } | ||||||
| browserslist-rs = { version = "0.19.0", default-features = false } | ||||||
| bumpalo = { version = "3.16.0", default-features = false } | ||||||
| bytes-str = { version = "0.2.5", default-features = false } | ||||||
| cargo_metadata = { version = "0.18.1", default-features = false } | ||||||
| changesets = { version = "0.2.2", default-features = false } | ||||||
| chrono = { version = "0.4.38", default-features = false } | ||||||
| codspeed-criterion-compat = { version = "3.0.4", default-features = true } | ||||||
| compact_str = { version = "0.7.1", default-features = false } | ||||||
| console_error_panic_hook = { version = "0.1.7", default-features = false } | ||||||
| copyless = { version = "0.1.5", default-features = false } | ||||||
| crc = { version = "2.1.0", default-features = false } | ||||||
| criterion = { version = "0.5.1", default-features = false } | ||||||
| dashmap = { version = "5.5.3", default-features = false } | ||||||
| dialoguer = { version = "0.10.2", default-features = false } | ||||||
| difference = { version = "2", default-features = false } | ||||||
| dragonbox_ecma = { version = "0.1.0", default-features = false } | ||||||
| either = { version = "1.10.0", default-features = false } | ||||||
| enumset = { version = "1.1.2", default-features = false } | ||||||
| flate2 = { version = "1.0", default-features = false } | ||||||
| getrandom = { version = "0.3.3", default-features = false } | ||||||
| glob = { version = "0.3.0", default-features = false } | ||||||
| globset = { version = "0.4.16", default-features = false } | ||||||
| hashbrown = "0.14.5" | ||||||
| hex = "0.4.3" | ||||||
| humansize = "2.1.3" | ||||||
| indexmap = "2.0.0" | ||||||
| is-macro = "0.3.5" | ||||||
| js-sys = "0.3.77" | ||||||
| jsonc-parser = "0.26.2" | ||||||
| kstring = "2.0.0" | ||||||
| lazy_static = "1.4.0" | ||||||
| lexical = "6.1.0" | ||||||
| lightningcss = "1.0.0-alpha.68" | ||||||
| lru = "0.16.1" | ||||||
| memchr = "2.6.1" | ||||||
| miette = "7.6.0" | ||||||
| hashbrown = { version = "0.14.5", default-features = false } | ||||||
| hex = { version = "0.4.3", default-features = false } | ||||||
| humansize = { version = "2.1.3", default-features = false } | ||||||
| indexmap = { version = "2.0.0", default-features = false } | ||||||
| is-macro = { version = "0.3.5", default-features = false } | ||||||
| js-sys = { version = "0.3.77", default-features = false } | ||||||
| jsonc-parser = { version = "0.26.2", default-features = false } | ||||||
| kstring = { version = "2.0.0", default-features = false } | ||||||
| lazy_static = { version = "1.4.0", default-features = false } | ||||||
| lexical = { version = "6.1.0", default-features = false, features = ["std", "parse-floats", "parse-integers"] } | ||||||
| lightningcss = { version = "1.0.0-alpha.68", default-features = false } | ||||||
| lru = { version = "0.16.1", default-features = false } | ||||||
| memchr = { version = "2.6.1", default-features = false } | ||||||
| miette = { version = "7.6.0", default-features = false } | ||||||
| napi = { version = "3", default-features = false } | ||||||
| napi-build = "2" | ||||||
| napi-build = { version = "2", default-features = false } | ||||||
| napi-derive = { version = "3", default-features = false } | ||||||
| new_debug_unreachable = "1.0.6" | ||||||
| nom = "7.1.3" | ||||||
| ntest = "0.7.2" | ||||||
| num-bigint = "0.4.3" | ||||||
| num_cpus = "1.13.1" | ||||||
| once_cell = "1.19.0" | ||||||
| owo-colors = "4.2.1" | ||||||
| new_debug_unreachable = { version = "1.0.6", default-features = false } | ||||||
| nom = { version = "7.1.3", default-features = false } | ||||||
| ntest = { version = "0.7.2", default-features = false } | ||||||
| num-bigint = { version = "0.4.3", default-features = false } | ||||||
| num_cpus = { version = "1.13.1", default-features = false } | ||||||
| once_cell = { version = "1.19.0", default-features = false, features = [ | ||||||
| "std", | ||||||
| ] } | ||||||
| owo-colors = { version = "4.2.1", default-features = false } | ||||||
| par-core = { version = "2.0.0", default-features = false } | ||||||
| par-iter = "2.0.0" | ||||||
| parking_lot = "0.12.1" | ||||||
| path-absolutize = "3.0.11" | ||||||
| path-clean = "1.0" | ||||||
| pathdiff = "0.2.1" | ||||||
| petgraph = "0.7.1" | ||||||
| phf = "0.11.2" | ||||||
| pretty_assertions = "1.3" | ||||||
| proc-macro2 = "1.0.24" | ||||||
| quote = "1.0.7" | ||||||
| radix_fmt = "1.0.0" | ||||||
| rand = "0.8.5" | ||||||
| rayon = "1.7.0" | ||||||
| regex = "1.5.4" | ||||||
| regress = "0.10.3" | ||||||
| relative-path = "1.6.1" | ||||||
| reqwest = "0.11.14" | ||||||
| rustc-hash = "2" | ||||||
| ryu-js = "1.0.0" | ||||||
| scoped-tls = "1.0.1" | ||||||
| semver = "1.0.20" | ||||||
| seq-macro = "0.3" | ||||||
| serde = "1.0.225" | ||||||
| serde-wasm-bindgen = "0.6.5" | ||||||
| serde_derive = "1.0.225" | ||||||
| serde_json = "1.0.140" | ||||||
| sha1 = "0.10.6" | ||||||
| sha2 = "0.10.8" | ||||||
| shrink-to-fit = "0.2.1" | ||||||
| siphasher = "0.3.9" | ||||||
| smallvec = "1.8.0" | ||||||
| smartstring = "1.0.1" | ||||||
| smol_str = "0.2.0" | ||||||
| st-map = "0.2.0" | ||||||
| string_cache = "0.8.7" | ||||||
| swc_sourcemap = "9.3.4" | ||||||
| syn = "2" | ||||||
| tempfile = "3.6.0" | ||||||
| termcolor = "1.0" | ||||||
| thiserror = "1.0.30" | ||||||
| par-iter = { version = "2.0.0", default-features = false } | ||||||
| parking_lot = { version = "0.12.1", default-features = false } | ||||||
| path-absolutize = { version = "3.0.11", default-features = false } | ||||||
| path-clean = { version = "1.0", default-features = false } | ||||||
| pathdiff = { version = "0.2.1", default-features = false } | ||||||
| petgraph = { version = "0.7.1", default-features = false } | ||||||
| phf = { version = "0.11.2", default-features = false } | ||||||
| pretty_assertions = { version = "1.3", default-features = false, features = [ | ||||||
| "std", | ||||||
| ] } | ||||||
| proc-macro2 = { version = "1.0.24", default-features = false } | ||||||
| quote = { version = "1.0.7", default-features = false } | ||||||
| radix_fmt = { version = "1.0.0", default-features = false } | ||||||
| rand = { version = "0.8.5", default-features = false } | ||||||
| rayon = { version = "1.7.0", default-features = false } | ||||||
| regex = { version = "1.5.4", default-features = false } | ||||||
| regress = { version = "0.10.3", default-features = false, features = ["std"] } | ||||||
| relative-path = { version = "1.6.1", default-features = false } | ||||||
| reqwest = { version = "0.11.14", default-features = false } | ||||||
| rustc-hash = { version = "2", default-features = false } | ||||||
| ryu-js = { version = "1.0.0", default-features = false } | ||||||
| scoped-tls = { version = "1.0.1", default-features = false } | ||||||
| semver = { version = "1.0.20", default-features = false } | ||||||
| seq-macro = { version = "0.3", default-features = false } | ||||||
| serde = { version = "1.0.225", default-features = false } | ||||||
| serde-wasm-bindgen = { version = "0.6.5", default-features = false } | ||||||
| serde_derive = { version = "1.0.225", default-features = false } | ||||||
| serde_json = { version = "1.0.140", default-features = false, features = [ | ||||||
| "alloc", | ||||||
| ] } | ||||||
| sha1 = { version = "0.10.6", default-features = false } | ||||||
| sha2 = { version = "0.10.8", default-features = false } | ||||||
| shrink-to-fit = { version = "0.2.1", default-features = false } | ||||||
| siphasher = { version = "0.3.9", default-features = false } | ||||||
| smallvec = { version = "1.8.0", default-features = false } | ||||||
| smartstring = { version = "1.0.1", default-features = false } | ||||||
| smol_str = { version = "0.2.0", default-features = false } | ||||||
| st-map = { version = "0.2.0", default-features = false } | ||||||
| string_cache = { version = "0.8.7", default-features = false } | ||||||
| swc_sourcemap = { version = "9.3.4", default-features = false } | ||||||
| syn = { version = "2", default-features = false, features = ["derive", "parsing", "printing", "clone-impls", "proc-macro"] } | ||||||
|
||||||
| syn = { version = "2", default-features = false, features = ["derive", "parsing", "printing", "clone-impls", "proc-macro"] } | |
| syn = { version = "2", default-features = false } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workspace
lexicaldependency adds explicit features["std", "parse-floats", "parse-integers"]when disabling default features. This is good practice as lexical requires these for basic functionality. Consider documenting why these specific features are needed to help future maintainers understand the requirement.