Skip to content

docs: tidy lead-effort note and report nits after batch 403 - #422

Merged
sv-tmueller merged 2 commits into
mainfrom
docs/415-tidy-batch-403
Oct 1, 2026
Merged

sv-tmueller merged 2 commits into
mainfrom
docs/415-tidy-batch-403

Conversation

@sv-tmueller

Copy link
Copy Markdown
Owner

Closes #415. Part of batch #417. Lean track (docs only; no .claude/agents, skills, workflows, or code).

Changes

  • .claude/team-guide.md: the refinement-only note now says to type /effort xhigh before replying "dispatch" or "file only", and that /effort high writes a persistent per-model override into settings.json (owner-confirmed 2026-10-01) which /effort xhigh undoes.
  • docs/reviews/2026-09-28-lead-effort-comparison.md: /effort high and /effort xhigh wording (was --effort high); original no-writes window start 10:56:00Z; "this fix round" replaced by "on 2026-09-30, during the PR A/B: lead effort, Opus 5.5 at high vs xhigh, on the advisor refine task #408 review"; "cache-cold" dropped; H6 artifact effect restated (without it the gap would be 0, not 0.33, so condition 1 holds with more room than reported); judge-layout mismatch attributed to the pre-registered judge layout.
  • docs/reviews/2026-09-28-lead-effort-comparison-data.json: no_writes_check_h4_h6.checked_utc is now the date only (2026-09-30), not the 00:00:00Z placeholder.

Not touched: the frozen protocol file, tiers.lead, agent frontmatter, effort-policy.test.mjs, ~/.claude-work/settings.json. No score or result changed.

perTurnEffort check (read-only)

Session logs under ~/.claude-work/projects whose first record is after 2026-10-01 07:29Z: two exist, both show only perTurnEffort: xhigh (one session: 122 turns; the other: 18). No high value in either. Nothing copied into the repo.

Checks

npm test -> 383/383 pass, exit 0.

🤖 Generated with Claude Code

The team-guide note now names /effort and the persistent per-model
override it writes, and covers "file only" as well as "dispatch".
The report carries the Opus re-review nits from PR #408.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sv-tmueller

Copy link
Copy Markdown
Owner Author

Reviewer report, lean track, fix round 1/3 (batch #417)

VERDICT: CHANGES_REQUESTED
STAGE: spec (must-fix); the quality pass findings below were requested by the dispatch (writing style) and can go into the same fix round
FINDINGS:

  1. .claude/team-guide.md:137-139, must-fix: the PR removed the old instruction "Flip back to /effort xhigh" and put a description in its place ("is what undoes it"), so the note no longer tells the lead to switch back. That is the step that was forgotten and kept every Opus session at high. Fix: replace the sentence Typing /effort xhigh before replying "dispatch" or "file only" is what undoes it; both replies go on to section 3 (File), and sections 3-6 and every other seat are unaffected. with Switch back to /effort xhigh before replying "dispatch" or "file only"; typing it is what undoes the override. Both replies go on to section 3 (File); sections 3-6 and every other seat are unaffected.
    Evidence: issue Tidy up after batch #403: team-guide effort note, report nits, Opus back on xhigh #415 criterion 1, "The team-guide note says to switch back to /effort xhigh before replying "dispatch" or "file only"."
  2. .claude/team-guide.md:134-136, should-fix: a bare settings.json reads like the repo's .claude/settings.json, which this same file calls settings.json at line 247. The owner's override was in the user-level file. Fix: replace the sentence with Typing /effort highwrites a persistent per-model override into the user-levelsettings.json in the config dir (owner-confirmed 2026-10-01), so it stays in force in every later session.
    Evidence: team-guide.md:247 "settings.json (full annotated tree: ...)" refers to the repo's .claude/settings.json.
  3. docs/reviews/2026-09-28-lead-effort-comparison.md:28-29, should-fix: section 1 still describes the note as "may run at high, flipped back to xhigh before replying "dispatch."", but section 7 (line 240) now says "dispatch" or "file only". The report now contradicts itself. Fix: replace that text with advisor sections 1-2 may run at /effort high, flipped back to /effort xhigh before replying "dispatch" or "file only."
    Evidence: criterion 2, "The report says /effort high and /effort xhigh ... wherever it describes the team-guide note."
  4. docs/reviews/2026-09-28-lead-effort-comparison.md:167,172,240,266, nit: the edited lines run to 97-101 columns, but the surrounding prose wraps at about 76. Reflow those paragraphs.
    Evidence: the four added lines are 99, 101, 97 and 99 characters long.
  5. .claude/team-guide.md:134-135 and report.md:11-12, nit: the code span /effort high breaks across a line. It renders fine, but grep '/effort high' misses it (PR A/B: lead effort, Opus 5.5 at high vs xhigh, on the advisor refine task #408's lesson was to grep every quote of a renamed term). Keep each span on one line.
    Evidence: "Typing /effort" / "high writes" and "to /effort" / "high.**"
  6. commit 2e1179c body, nit: the body says what changed, not why. Fix: say why, for example Batch #403 left the note silent on "file only" and on the persistent /effort override, which kept later Opus lead sessions at high.
    Evidence: .claude/process-core.md "Commits", "The body explains why, not what."
    Verified clean: criteria 3-10 are met. The frozen protocol, .claude/adapters/claude-code.json (tiers.lead), .claude/agents, .claude/skills, .claude/workflows and .claude/workflows/__tests__/effort-policy.test.mjs are unchanged, and no scores changed. The changed files have no em dashes and no banned phrases. The judge-layout bullet's protocol quotes match the protocol (lines 189-191 vs 51-53). The perTurnEffort cutoff of 07:29Z is consistent: it is now 08:40Z, so the issue's "09:29" must be local time (UTC+2).
    CHECKS: checked-out SHA 2e1179c. git ls-remote --exit-code origin docs/415-tidy-batch-403 exit 0; git fetch origin docs/415-tidy-batch-403 exit 0; git checkout --detach FETCH_HEAD exit 0; npm test exit 0 (383/383 pass). The dispatch gave no dependency environment, and none was needed because the suite has zero deps. git diff --quiet 2749bae HEAD -- <protocol> .claude/adapters .claude/agents .claude/skills .claude/workflows exit 0.
    LESSONS: when two acceptance criteria are merged into one sentence, check each one on its own afterwards; rewording an instruction as a description quietly drops the instruction.

@sv-tmueller sv-tmueller mentioned this pull request Oct 1, 2026
4 of 19 tasks
Batch #403 left the note silent on "file only" and on the persistent
/effort override, which kept later Opus lead sessions at high; the
first pass also dropped the switch-back instruction. This restores the
instruction, states the override's persistence and scope, aligns the
report's section 1 with the note, and reflows the edited paragraphs
with each /effort code span on one line.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sv-tmueller

Copy link
Copy Markdown
Owner Author

Reviewer report, lean track, re-review after fix round 1/3 (batch #417)

VERDICT: APPROVE
STAGE: both clean
FINDINGS: none
Round-1 findings 1-5 are fixed in 431cec0.

  1. .claude/team-guide.md:137-139 uses the required "Switch back to /effort xhigh before replying "dispatch" or "file only"; typing it is what undoes the override. Both replies go on to section 3 (File); ..." text word for word.
  2. .claude/team-guide.md:134-137 uses the required "user-level settings.json in the config dir" sentence word for word.
  3. docs/reviews/2026-09-28-lead-effort-comparison.md:28-30 now says "/effort high, flipped back to /effort xhigh before replying "dispatch" or "file only."", which matches section 7 (lines 241-242).
  4. Reflow: git diff -w --word-diff 2e1179c 431cec0 shows word changes only from findings 1-3. The one other change is from the section 1 reflow: "contamination-" plus a line break plus "gate" became "contamination-gate". The old line break put a stray space into the rendered text, so joining it changes no word. No added line in either .md file runs past 80 columns. The report's remaining over-80 lines (4, 6, 15, 63, 68-70, 201) are links, a table and a path, and this PR leaves them untouched.
  5. No added line has an odd number of backticks, so every /effort ... span stays on one line (team-guide 135 and 138, report 12, 29, 240-241, 279).
    Finding 6 was handled under Decision 7, and 431cec0's body now says why.
    Pass 1 on the whole diff (2749bae..431cec0): all three files and every change trace to issue Tidy up after batch #403: team-guide effort note, report nits, Opus back on xhigh #415's criteria. Nothing extra. The protocol file, .claude/adapters, .claude/agents, .claude/skills and .claude/workflows are unchanged. No scores changed.
    Pass 2: the added lines have no em dashes and no banned phrases. Neither changed .md file still says --effort. data.json parses, and only checked_utc changed ("2026-09-30"). .claude/skills/tm-advisor/SKILL.md:88-115 confirms that "file only" also goes on to section 3 (File).
    CHECKS: checked-out SHA 431cec0. git ls-remote --exit-code origin docs/415-tidy-batch-403 exit 0; git fetch origin docs/415-tidy-batch-403 exit 0; git checkout --detach FETCH_HEAD exit 0; npm test exit 0 (383/383 pass); git diff --quiet 2749bae 431cec0 -- <protocol> .claude/adapters .claude/agents .claude/skills .claude/workflows exit 0. The dispatch gave no dependency environment, and the suite has zero deps.

@sv-tmueller
sv-tmueller marked this pull request as ready for review October 1, 2026 08:46
@sv-tmueller
sv-tmueller merged commit 2bdf754 into main Oct 1, 2026
2 checks passed
@sv-tmueller
sv-tmueller deleted the docs/415-tidy-batch-403 branch October 1, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tidy up after batch #403: team-guide effort note, report nits, Opus back on xhigh

1 participant