Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the internal AsyncAbortController to eliminate any usage and to properly support both function listeners and EventListenerObject listeners while tracking abort-handler completion.
Changes:
- Replaces
Promise<any>[]withPromise<unknown>[]for stronger typing. - Binds and wraps
AbortSignal.addEventListenerto supportEventListenerOrEventListenerObjectand forward theEventargument. - Awaits async abort handlers by resolving a tracked promise per registered abort listener.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24253550042Coverage increased (+0.05%) to 80.882%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
ferhatelmas
force-pushed
the
ferhat/abort-controller
branch
2 times, most recently
from
4f3cea2 to
2ea7e4e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
ferhat/abort-controller
branch
from
2ea7e4e to
8a4fbff
Compare
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/abort-controller
branch
from
8a4fbff to
e6eb0ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
Using any.
What is the new behavior?
No any. Event is also passed to listener as expected.
Additional context
It's more generic to handle event listener object as well and add new coverage for it.
Handle removing by capturing identity in weak map.
Related to #922, extracted for behavioral changes.