Repository navigation
refactor: remove unnecessary signal handler - #313
Merged
Merged
Conversation
imor
force-pushed
the
rs/remove-unnecessary-signal-handler
branch
from
October 8, 2026 08:27
9b5c0fa to
e14c28c
Compare
utkarash2991
approved these changes
Oct 9, 2026
imor
force-pushed
the
rs/remove-unnecessary-signal-handler
branch
from
October 11, 2026 09:46
e14c28c to
c40e6a6
Compare
imor
force-pushed
the
rs/remove-unnecessary-signal-handler
branch
from
October 11, 2026 12:48
c40e6a6 to
d3d6bdf
Compare
steve-chavez
approved these changes
Oct 13, 2026
imor
force-pushed
the
rs/remove-unnecessary-signal-handler
branch
4 times, most recently
from
October 13, 2026 06:48
2824b10 to
e6fd384
Compare
Base automatically changed from
rs/unblock-signals-after-installing-signal-handlers
to
master
October 13, 2026 08:06
Installing a sigusr1 signal handler in pg_net background woker was redundant because the default signal handler already calls SetLatch on MyLatch, which is the same as MyProc->procLatch which we assign to worker_state->shared_latch. In the original commit when this code was introduced the shared_latch was not the same as MyLatch necessitating a custom handler, now that is no longer the case hence we can remove this redundant code.
imor
force-pushed
the
rs/remove-unnecessary-signal-handler
branch
from
October 13, 2026 08:07
e6fd384 to
ada91a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing a sigusr1 signal handler in pg_net background worker was redundant because the default signal handler already calls
SetLatchonMyLatch, which is the same asMyProc->procLatch, which we assign toworker_state->shared_latch. In the original commit when this code was introducedshared_latchwas not the same asMyLatchnecessitating a custom handler, now that is no longer the case hence we can remove this redundant code.