Configurable resolution#198
Open
tasuki wants to merge 6 commits intosuomipelit:masterfrom
Open
Conversation
akx
reviewed
Mar 4, 2025
Collaborator
akx
left a comment
There was a problem hiding this comment.
Quick initial comment before I look through all of this:
Based on
$ ag -o "scr_._size\s*/\s*\d+" | grep : | cut -f3 -d: | sort | uniq -c | sort -nr
45 scr_x_size/2
32 scr_x_size / 2
12 scr_y_size / 20
10 scr_y_size / 2
8 scr_x_size / 20
5 scr_x_size/4
it would probably make sense to at least introduce the variables scr_x_half_size and scr_y_half_size, so as to
- make the intent clearer where these are being used
- avoid two different whitespace "spellings" of the division
- (and to avoid the extra runtime divisions, not that that matters on modern hardware)
Author
|
I actually used to have a The right solution would imo be to build up more powerful abstractions: a lot of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195
This is still a work in progress⚠️ 🚧 but I'm looking for your comments!