Drop the unused djet extra - #919
Merged
Merged
Conversation
The pytest migration (#893) removed the last `from djet import assertions`, so nothing in djoser or its test suite imports djet any more. The extra still shipped in published metadata and CI still installed it on all 28 matrix jobs. djet was never used by library code and never documented, so `pip install djoser[djet]` only ever installed a test helper djoser does not call. Requesting an extra that no longer exists is a warning, not an error, so pinned `djoser[djet]` installs keep working. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RUccbzSjBjZYvJtzbLjLo7
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 27 27
Lines 908 908
=======================================
Hits 902 902
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
djetfrom djoser entirely. The test suite relies on pytest alone.Why
The pytest migration (#893) removed the last
from djet import assertions. Since then djet has survived only as:djoser[djet])--extra djetinstall on all 28 CI matrix jobsTwo facts from full-history searches:
djoser/has never imported djet —git log --all -S'djet' -- djoser/returns nothinggit log --all -S'djet' -- docs/ README.rstreturns nothingSo
pip install djoser[djet]only ever installed a test helper that djoser does not call — a development dependency leaking into published metadata.Compatibility
Requesting an extra that no longer exists is a warning, not an error. Verified against the released 2.3.4:
So existing
djoser[djet]pins keep installing; they just stop pulling in djet.Changes
djetfrom[project.optional-dependencies]--extra djetfrom the three test-suite jobsuv lock— 101 → 100 packages,provides-extras = ["webauthn"]Verified
uv sync --group test --extra webauthn), confirmed djet is absent from it, and ran the suite there: 206 passed — the strongest evidence it is unusedmake run-hooks— all hooks passmake build— wheel METADATA now advertises onlyProvides-Extra: webauthn; the four runtime dependencies are unchangeduv lock --check— cleanmake docs— 6 warnings, the pre-existing baseline🤖 Generated with Claude Code
https://claude.ai/code/session_01RUccbzSjBjZYvJtzbLjLo7