fix: Further WHIR audit fixes (chiefly consistency checks in WhirProofShape construction)#2706
Open
erabinov wants to merge 17 commits into
Open
fix: Further WHIR audit fixes (chiefly consistency checks in WhirProofShape construction)#2706erabinov wants to merge 17 commits into
erabinov wants to merge 17 commits into
Conversation
Contributor
|
c3c0373 to
2c1cbbb
Compare
…d from the round_areas
… of the extension degree
d53df26 to
f26f108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main fixes in this PR are:
into_extension()methods on Buffer and Tensor to CPU-specific implementations that use safe Rust. The generic-backend versions are not needed.WhirProofShapestruct (ones that could be deduced from equalities likestarting_domain_log_size = starting_interleaved_log_height + starting_inv_log_rate), and created a new structUncheckedWhirProofShapethat has all the same fields butpub. Made a constructor forWhirProofShapethat takes in anUncheckedWhirProofShapeand performs consistency checks on the shape, panicking if the unchecked shape is invalid. TheWhirProofShapestruct fields are only accessed via getters.