Repository navigation
Support Twitch-only 1440p Auto Optimizer and improve EB compatibility - #1799
Merged
Merged
Conversation
…ing compatibility
aleksandr-voitenko
changed the title
aleksandr-voitenko
changed the title
Extract the ordinary multistream bitrate cap into a shared policy helper and test it without requiring a real hardware benchmark to succeed. Preserve stricter limits, single-platform allowances, and Twitch-managed ladders, and retain the existing startup and cancellation integration coverage.
Apply Twitch's paired-resolution rule only to measured recommendations, while preserving saved vertical tuples and request limits for estimates. Cover absent and failed probes, retain measured-pair validation tests, and exercise 1440p fallback through the public API. Clarify the estimate contract in the API comments.
Stop candidate descent after cancellation, including when a blocking Twitch configuration request fails or succeeds. Add local-only integration coverage for stalled 1440p and 1080p requests, session reuse, and the normal 1440p-to-1080p fallback.
sandboxcoder
approved these changes
Oct 8, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes native hardware, network-probe, and provider-configuration behavior that was only manually validated on Windows.
0 open findings
What changed in this PR
Adds Twitch-only 1440p optimization while preserving conservative multistream limits and improving Enhanced Broadcasting compatibility.
Changes:
- Adds Twitch-only 1440p/8000 Kbps policy and 6000 Kbps multiplatform caps.
- Supports 1440p horizontal/1080p vertical Enhanced Broadcasting with HEVC preservation.
- Adds configuration fallback/warning handling, encoder-query IPC registration, and tests.
| File | Description |
|---|---|
tests/osn-tests/src/test_osn_get_available_encoders.ts |
Tests Enhanced Broadcasting encoder queries. |
tests/osn-tests/src/test_osn_auto_optimizer.ts |
Tests 1440p eligibility and saved Dual Format settings. |
tests/osn-tests/src/test_osn_auto_optimizer_configuration.ts |
Tests configuration retries and cancellation. |
source/auto-optimizer-quality-policy.hpp |
Defines 1440p and multistream quality policy. |
source/auto-optimizer-enhanced-broadcasting-policy.hpp |
Adds HEVC filtering, pairing, and fallback classification. |
obs-studio-server/source/osn-enhanced-broadcasting-simple-streaming.cpp |
Registers the encoder-query IPC handler. |
obs-studio-server/source/osn-enhanced-broadcasting-advanced-streaming.cpp |
Registers the advanced encoder-query handler. |
obs-studio-server/source/nodeobs_auto_optimizer.cpp |
Implements optimizer caps, probes, fallback, and warnings. |
obs-studio-client/tests/auto-optimizer-quality-policy-test.cpp |
Covers new quality policies. |
obs-studio-client/tests/auto-optimizer-enhanced-broadcasting-policy-test.cpp |
Covers Enhanced Broadcasting policy changes. |
obs-studio-client/tests/auto-optimizer-client-contract-test.cpp |
Tests result validation and warning projection. |
obs-studio-client/source/auto-optimizer-client-contract.cpp |
Validates paired results and projects warnings. |
js/module.ts |
Documents the expanded public API behavior. |
js/module.d.ts |
Exposes output warnings in declarations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow capable Twitch-only setups to use 1440p while keeping multistream recommendations conservative. Improve Enhanced Broadcasting compatibility and distinguish Twitch configuration limitations from measured performance problems.
Changes
Desktop handles content-resolution eligibility, applying recommendations, and user-facing messaging.
How Has This Been Tested?
Manually, Windows only.
Types of changes