Repository navigation
Fix custom stream destination settings staging - #1776
Merged
summeroff merged 3 commits intoSep 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation addresses the reported failure modes with comprehensive dual-destination regression coverage.
Pull request overview
Fixes RTMP server normalization when changing stream destinations, preventing invalid server settings and lost stream keys.
Changes:
- Validates common RTMP servers and preserves native URL formatting.
- Resolves automatic servers when switching to custom streaming.
- Adds typings and regression tests for both stream destinations.
File summaries
| File | Description |
|---|---|
obs-studio-server/source/nodeobs_settings.cpp |
Implements server reconciliation and resource handling. |
tests/osn-tests/src/test_nodeobs_settings.ts |
Tests destination-switching and URL normalization scenarios. |
js/module.ts |
Documents and types the legacy save API. |
js/module.d.ts |
Exposes the save API declaration. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a detailed description see:
#1775