Skip to content

marketing: remove product updates API hack #6262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesrupert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

marketing: remove product updates API hack #6262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions app/services/announcements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,13 +330,6 @@ export class AnnouncementsService extends Service {
const req = this.formRequest(endpoint);
try {
const resp = await jfetch<{ updates: IAnnouncementsInfo[]; lastUpdatedAt: number }>(req);

// HACK: API can return a sparse array of updates, which gets deserialized as an
// object with number keys. Check for this and convert it to an array if necessary.
if (resp.updates && !Array.isArray(resp.updates)) {
resp.updates = Object.values(resp.updates);
}

console.debug('Fetched product updates:', resp);
return resp;
} catch (e: unknown) {
Expand Down
Loading